Comments (4)
Probably we want that modifier ungreedy, like so:
$uri = preg_replace('#((?<=\?)|&)openid\..*?(?>=&|$)#','',$uri);
but I don't think the parameters would get mixed anyway.
Original comment by [email protected]
on 22 Nov 2010 at 8:14
from lightopenid.
That regex needs some work now that I look at it, but I think I made my point.
Original comment by [email protected]
on 22 Nov 2010 at 8:17
from lightopenid.
We need the "($this->data['openid_return_to'] != $this->returnUrl)", because
without it, someone could send an openid response meant for another relying
party, and it would still validate. That would enable a rogue RP to
authenticate into LightOpenID RP-s, effectively hijacking the user's account on
those sites.
Besides, the protocol requires that openid.return_to has to be checked, and
it's enough reason to do that. See section 11 and 11.1 of the spec for the
details.
As for the regex, I'll test it later and commit the fix if it works.
Original comment by [email protected]
on 22 Nov 2010 at 11:33
- Changed state: Accepted
from lightopenid.
I have slightly modified the regex and commited the fix.
Original comment by [email protected]
on 22 Nov 2010 at 3:30
- Changed state: Fixed
from lightopenid.
Related Issues (20)
- version 0.5 example works but not version 0.6 HOT 3
- Ax/SReg Params may be unsigned
- LightOpenId constructor fails when trusted root URL is less than 8 chars
- Problem with curl request on a server
- Missing: A License File HOT 2
- add composer support HOT 1
- wrong mimetype check in openid.php ? HOT 3
- Use Steam as provider HOT 1
- #-comments HOT 6
- returning clamed_id is a wrong approach HOT 5
- magic get/set methods HOT 3
- LightOpenID magic properties do not work with Twig template engine due to lack of __isset
- New release HOT 1
- keep waiting for localhost HOT 2
- Validation fails when there are accent in the required variable HOT 2
- Yahoo OpenID not working on newer versions of PHP/cURL [patch proposed]
- The regular expressions in htmlTag parse some valid responses incorrectly
- Support for OpenID Connect? HOT 1
- How to select eid applet language ?
- Unregistered domain error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightopenid.