A few questions about masterportfolio

[danielmarostica]

Hey @th3c0d3br34ker, awesome tips, it worked right away! I'd suggest a few changes in the Readme file to make future padawan's lives easier hehe

[ashutosh1919]

@danielmarostica , If you are rasing PR then keep following things in mind.

(1) If the repository is special, then push the code in branch develop and build in master branch. Then enable gh-pages on master.
(2) If the repository is not special, then whatever described right now will work

[th3c0d3br34ker]

Hey @danielmarostica welcome to the world of JavaScript.

1. You could fork/download as zip the source code, depends on what you want. If you want to use it just once and make a portfolio then I would suggest you to download as zip.
2. The git_data_fetcher just gathers data from your github account and allows you to put that data in your portfolio. If you head on the open source section, you would get what it does.
3. The generated code refers to the build folder that is produced by react scripts. Once you are done making changes, run npm run build .
4. GitHub does allow you to change the master branch to gh-pages... see here. If you still can't figure out, just upload the contents build folder in your master branch.

I hope this solves most of your problem. If you again run into problems feel free to ask. 😄

And Kudos to @ashutosh1919 for making such an amazing project!

[danielmarostica]

But I insist on this: even though you change the default branch to gh-pages, github does not allow anything other than master branch for the user page (user.github.io)

fastai/fastpages#119 (comment)

[ashutosh1919]

But I insist on this: even though you change the default branch to gh-pages, github does not allow anything other than master branch for the user page (user.github.io)

fastai/fastpages#119 (comment)

@danielmarostica , sorry that you faced the issue and Thank you so much @th3c0d3br34ker for giving assisatnce here. I got to know about this issue recently and working on it to resolve.

If you want to contribute to the project doc, feel free to raise PR for README.

Thanks again for raising the issue.

[danielmarostica]

@ashutosh1919 I will do so! I think my experience of building it out of zero experience with js will help.

[th3c0d3br34ker]

Yes, as @danielmarostica pointed out that you can't change the master branch of the this special repository only.

[danielmarostica]

You mention "Please don't use any other names" for the repository name. Why?

Keeping that in mind, is this still valid?
(2) If the repository is not special, then whatever described right now will work

[ashutosh1919]

Yes, I meant that if you are creating special repo, don't use any other name. You can use whatever you want for (2).

[ashutosh1919]

@danielmarostica , Please close this issue if you don't have any more questions.