gauge threshold bug about ngx-gauge

[ashish-chopra]

Issue Fixed.

Please update to the new version v1.0.0-beta.1.

I will soon release a final version 1.0.0 with an upgrade to ng 5.

[SpartanNico94]

Thank you very much

[SpartanNico94]

I've checked the source code and when you call NgxGauge.prototype._getForegroundColorByRange you sort thresholds and then you reverse and select the first. Now, suppose you are using my thresholds... if you call .sort() you get

(3) ["0", "100", "80"]
0: "0"
1:"100"
2:"80"
length:3
__proto__:Array(0)

This is because you are sorting by strings and not using real number values, so 100 comes before 80.
To resolve this you should sort by real number. I've changed your code adding a simple function and changing NgxGauge.prototype._getForegroundColorByRange function (inside ngx-gauge.es5.js). Here's my code

function sortByNumber(a, b) { return Number(a) > Number(b); }

NgxGauge.prototype._getForegroundColorByRange = function (value) {
        var /** @type {?} */ match = Object.keys(this.thresholds)
            .filter(function (item) { return isNumber(item) && Number(item) <= value; })
			.sort(sortByNumber).reverse()[0];
        return match !== undefined
            ? this.thresholds[match].color || this.foregroundColor
            : this.foregroundColor;
};

This solved the problem and gauge will load the proper threshold.

I'll be glad if you would fix this with a new release, and remove the console.log found in this issue #4.

Please reply when you fix this so i can download the new version. Thanks :)