Comments (2)
I don't know if this is a good idea, or at least we need to define this flow a bit better. There are two situations to consider: a user is able to submit, and a user is unable to submit (say, due to a network outage).
If they are able to submit, then having the close button delete works -- it just duplicates the effect of the delete button. Submit, obviously, still submits.
If they are unable to submit, then there's a bit of an issue. Presumably they want to keep this evidence around and retry later. If the close button and the delete button delete the content, and submit doesn't work... then the only option; is to keep the window open. What should be done in this case? Are we okay with just requiring that the user keep the always-on-top window open, or to duplicate their work later, or should we allow saving with the intent to submit later?
Some possible options if we want to allow saving:
- Only show the "save & close" button after the user tries to submit (And fails)
- Submit implicitly saves, and if there's an issue submitting, a prompt indicates this, and then closes anyway (allowing the user to go to the management area to re-submit)
- Some background process tries to submit this periodically, if the initial submit fails
- Close works conditionally: If not submitted, deletes. If a submit has occurred, it acts as a save.
Thoughts?
from ashirt.
Closing per off-line conversation
from ashirt.
Related Issues (20)
- Sign windows builds
- Dialogs missing buttons
- Crash on quit HOT 1
- Crash on delete of evidence when tags have not yet been returned HOT 1
- Duplicate evidence capture dialogs on windows
- Produce debug builds/debug data HOT 1
- Remove icon in dock on MacOS
- Icon not changing to theme update HOT 3
- Windows screenshot exec
- New Operations are not added to the list until restart
- Update set-output in actions
- Cached action isn't setup correctly
- Submission of multiple tag using the linux client breaks client and server
- Automatically determine linux screen capture application
- No feedback on no operation selected HOT 1
- Client submits tags that have been deleted from the evidence creation modal HOT 2
- xdg-freedesktop-portal use
- Out of Date build directions in Readme_Developer.md HOT 1
- Replace deprecated actions HOT 1
- Upgrade altool to notarytool HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ashirt.