Comments (3)
I just looked through the code to gauge the lift and saw you already use occurred_at
as the default timestamp by which the timeline is sorted. I'm struggling to think of a different name for the editable field but wanted to clear up the confusion since my proposed property name already exists.
from ashirt-server.
We're open to discussion about this. It's designed as is to prevent tampering with data and preserve the data. We've definitely run into issues where evidence had to be captured later and the timeline ends up being out of order. Like you mentioned there is an occurred_at field which is what we currently use for sorted evidence. When evidence is created in the web UI that defaults to the same value as created_at (the current time). When using a client like ASHIRT, the occurred_at timestamp is the timestamp that the client records and the created_at is the time the server creates the evidence. We probably want to be able to maintain that. Maybe we can add another adjusted_timestamp field that is user controllable and we can sort by that; defaulting to the value in occurred_at if adjusted_timestamp isn't set?
- Would you want everyone with write permissions to be able to adjust a timestamp or only admins of an operation?
- Would you want to see some sort of UI icon or other denotation that the timestamp for a specific evidence has been adjusted in the timeline?
from ashirt-server.
Anyone with write should be able to modify the adjusted_at timestamp.
I think when viewing a single piece of evidence where the timestamps differ, a subdued timestamp or marker could appear under the description.
Having a button or toggle in the menu bar (or some other prominent place) that states whether the current view is being sorted by occurrence/adjusted date would be ideal.
from ashirt-server.
Related Issues (20)
- Allow optional descriptions for the default operation tags #6
- Add dependencies and health checks to docker compose files
- Code viewer (ace-editor) height is stuck at 6 lines
- Decide on the future of the HTTP stack and plan out changes HOT 1
- .env.web file? HOT 2
- Re-evaluate OIDC2 behavior
- S3 URLs not used in /findings HOT 1
- Setup weekly rebuilds of main HOT 1
- Add validation to the create evidence form
- Metadata line wrapping HOT 1
- Permalink redirects to query with invalid uuid HOT 4
- Project-specific variables HOT 4
- Metadata search breaks when using multiple terms
- Improve Timeline Image Loading HOT 1
- Prefix access keys and secret keys with a known value
- Container name cleanup
- Improvements to logging
- AISHIRT
- Rebuild main and release branches HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ashirt-server.