Comments (3)
Hi @asharanjith and @AhmadiGu ,
Good job so far!
You still need to work on some issues to go to the next project, but you are almost there!
Highlights
π Descriptive Issueβ
π Great working on the setup of the project Kanban board β
Required Changes β»οΈ
Check the comments under the review.
- You have set up the board nicely and have cards assigned to team members π π― However, Each project requirement should have at least one card in the Kanban board but now the requirement "Create a navigation menu that allows users to open all of the pages you created" does not have a corresponding card in the board so make sure that you create an additional card with this requirement π and submit this same issue link for review π
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from food-recipes-app.
Hi @asharanjith and @AhmadiGu ,
Good job so far!
You still need to work on some issues to go to the next project, but you are almost there!
Highlights
π Descriptive Issueβ
π Great working on the setup of the project Kanban board β
Required Changes β»οΈ
Check the comments under the review.
- You have set up the board nicely and have cards assigned to team members π π― However, Each project requirement should have at least one card in the Kanban board but now the requirement "Create a navigation menu that allows users to open all of the pages you created" does not have a corresponding card in the board so make sure that you create an additional card with this requirement π and submit this same issue link for review π
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from food-recipes-app.
Hi @Team
Your board setup is complete!
Congratulations! π
Highlights
- Good setup π―
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- N/A
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from food-recipes-app.
Related Issues (20)
- Create Food Model 1 pt
- Create Recipe Model 1pt
- Create Recipe Food Model 1pt
- Create Login Page + Registration Page 4pt
- Create Recipes list page 3pt
- Create Recipe details page 4pt
- Create Food list Page 3pt
- Create Public Recipe List page 2pt
- General shopping list view 3.5pt
- Fix n+1 queries and write unit test for User 1pt
- Fix n+1 queries and write unit test for Food 1pt
- Fix n+1 queries and write unit test for Recipe Food 1pt
- Fix n+1 queries and write unit test for Recipe 1pt
- Integration specs for foods page 1pt
- Integration specs for recipes page 1pt
- Integration specs for recipe details page 2pt
- Integration specs for public recipe page 1pt
- Integration specs for general shopping list page 1pt
- Create a navigation menu 0.5pt
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from food-recipes-app.