Coder Social home page Coder Social logo

Comments (11)

zachdaniel avatar zachdaniel commented on July 20, 2024

How strange. I'll take a look shortly.

from ash_postgres.

zachdaniel avatar zachdaniel commented on July 20, 2024

Fixed in a combination of fixes to ash and ash_postgres. Cutting a fixed release for ash_postgres now, ash fix is released.

from ash_postgres.

ahey avatar ahey commented on July 20, 2024

Hey @zachdaniel , thank you for looking into it! This has fixed the compilation error, however the test is still failing due to the calculation returning the wrong value. This is also occurring for me locally.

from ash_postgres.

zachdaniel avatar zachdaniel commented on July 20, 2024

Yep! Meant to update this issue. I'm investigating currently.

from ash_postgres.

zachdaniel avatar zachdaniel commented on July 20, 2024

Can you try out main of ash_postgres for me?

from ash_postgres.

ahey avatar ahey commented on July 20, 2024

Sure – same issue :(

1) test channel: first_member and second member (AshPostgres.Test.ComplexCalculationsTest)
     test/complex_calculations_test.exs:64
     Assertion with == failed
     code:  assert channel.name == user_2.name
     left:  "User 1, User 2"
     right: "User 2"
     stacktrace:
       test/complex_calculations_test.exs:114: (test)

from ash_postgres.

zachdaniel avatar zachdaniel commented on July 20, 2024

Sorry, I think I hadn't pushed up the fix 🀦 I pushed it up just now with another separate fix.

from ash_postgres.

ahey avatar ahey commented on July 20, 2024

OK this is making more sense now. I was running postgres v13.3 locally, and the test fails on that version. The github workflow uses latest postgres which is 16.1, and the test is passing. I installed 16.1 locally and the test does indeed pass!

We might therefore need to bump the minimum version of postgres supported by ash_postgres (currently 10), or find out why it doesn't work on v13.3.

I'm able to use a newer version of postgres in this project so this is solved for me now πŸ₯³

from ash_postgres.

zachdaniel avatar zachdaniel commented on July 20, 2024

Interestinggggggg. I'm going to add version 10 and 13.3 to our testing matrix I think.

from ash_postgres.

zachdaniel avatar zachdaniel commented on July 20, 2024

I really can't see why this would be a problem on pg 13 😒

from ash_postgres.

ahey avatar ahey commented on July 20, 2024

I have tested locally, and your latest commits to ash_postgres appear to have fixed the issue on all postgres versions πŸ₯³

Thank you πŸ˜„

from ash_postgres.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.