Coder Social home page Coder Social logo

Comments (15)

sudo-suhas avatar sudo-suhas commented on June 4, 2024 2

I'll test it tomorrow and update here.

from autodll-webpack-plugin.

dliu120 avatar dliu120 commented on June 4, 2024 1

I am also seeing this failure as well

from autodll-webpack-plugin.

sudo-suhas avatar sudo-suhas commented on June 4, 2024 1

Hey @AlexDel, this issue was fixed sometime back but we somehow missed closing it. I am also on a Windows system so I double checked it to be sure and no tests are failing. I'll close the issue as well but if you do happen to face any issue, please open a new one.

Is there any stuff I can facilitate with investigation and devloping?

Thanks for this though!

from autodll-webpack-plugin.

sudo-suhas avatar sudo-suhas commented on June 4, 2024

Opened issue upstream - yarnpkg/yarn#3827.

from autodll-webpack-plugin.

sudo-suhas avatar sudo-suhas commented on June 4, 2024

This fails due to memory-fs detecting that '/my/cache/dir' which gets normalized to '\my\cache\dir\bundles' is not a valid path for windows.

Not sure how to fix this. Hopefully there's something wrong only with the test on windows and the functionality is fine.

from autodll-webpack-plugin.

asfktz avatar asfktz commented on June 4, 2024

Hi, @sudo-suhas
Is this still relevant?

from autodll-webpack-plugin.

sudo-suhas avatar sudo-suhas commented on June 4, 2024

This test still fails on windows.
In addition to that, this change is completely breaking the yarn test command:

$ babel-node ./node_modules/.bin/tape specs/**/*.spec.js | faucet
E:\Projects\repos\autodll-webpack-plugin\node_modules\.bin\tape:2
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
          ^^^^^^^

SyntaxError: missing ) after argument list
    at createScript (vm.js:74:10)
    at Object.runInThisContext (vm.js:116:10)
    at Module._compile (module.js:533:28)
    at Module._extensions..js (module.js:580:10)
    at Object.require.extensions.(anonymous function) [as .js] (E:\Projects\repos\autodll-webpack-plugin\node_modules\babel-register\lib\node.js:152:7)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Function.Module.runMain (module.js:605:10)
    at Object.<anonymous> (E:\Projects\repos\autodll-webpack-plugin\node_modules\babel-cli\lib\_babel-node.js:154:22)
not ok 1 no plan found
not ok 2 no assertions found
⨯ fail  2
error Command failed with exit code 1.

from autodll-webpack-plugin.

sudo-suhas avatar sudo-suhas commented on June 4, 2024

Made PR #38 which solves the yarn test failure on windows.

from autodll-webpack-plugin.

asfktz avatar asfktz commented on June 4, 2024

You're awesome as usual, thanks!

from autodll-webpack-plugin.

sudo-suhas avatar sudo-suhas commented on June 4, 2024

Test createMemory should have bundles still fails on windows. Reopen please? Sorry for the confusion.

from autodll-webpack-plugin.

asfktz avatar asfktz commented on June 4, 2024

NP

from autodll-webpack-plugin.

akuznetsov-gridgain avatar akuznetsov-gridgain commented on June 4, 2024

Hi, we also need this fix!

from autodll-webpack-plugin.

asfktz avatar asfktz commented on June 4, 2024

Ohhh, can't believe I let this Issue wait for so long!
@sudo-suhas, it this still relevant to the current master?

from autodll-webpack-plugin.

sudo-suhas avatar sudo-suhas commented on June 4, 2024

As I noted in #52 (comment), the test is still failing. But now I am not sure if this is a bug in the specs or the src. See #81.

from autodll-webpack-plugin.

AlexDel avatar AlexDel commented on June 4, 2024

Hello guys! We are looking forward for applying you cool lib on our win servers. Is there any stuff I can facilitate with investigation and devloping? We really need this fix :)

from autodll-webpack-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.