Comments (7)
For the watch option, I think it should be an array of resolved paths that we should watch.
{
watch: [
path.resolve('package.json'),
path.resolve('package-lock.json'),
path.resolve('yarn.lock'),
path.resolve('node_modules')
path.resolve('webpack.config.js')
]
}
And save hashes of those files and directory in the cache folder. So instead of just comparing JSON, isCacheValid
will compare hashes of files, folder, and setting. This would affect the initial build time but will make overall validation more accurate in the next start.
Then, the compiler needs to run in watch mode if watch
property is truthy in the setting. I haven't thought through the implementation of this phase, should the main compiler run if the DLL compiler finished compiling?
from autodll-webpack-plugin.
btw I've written a similar implementation of this plugin in this CRA PR. It would be nice if we can join the feature.
from autodll-webpack-plugin.
Hi, @viankakrisna! good to see you here (:
I apologize for the late response, the real world got waaay too busy for me in the last few days.
Bad timing I guess 😅
Thanks for the PRs! I am eager to dive into it. That's my plan for tomorrow.
from autodll-webpack-plugin.
No problem! Just ping me if you need anything :)
from autodll-webpack-plugin.
Oh and one more thing!
Please keep in mind that more than one instance of the plugin can be used.
Like in this case: #2 (comment)
from autodll-webpack-plugin.
that's making cleanup trickier, maybe we can set up a counter inside the constructor?
from autodll-webpack-plugin.
updated #13 with NODE_ENV and instance id
from autodll-webpack-plugin.
Related Issues (20)
- 'Is valid cache' is aways false
- How to DevExpress to DLL? HOT 3
- got error when use dynamic import
- Only updating package produces wrong broken dll-links when using chunkhashes
- AutoDLL not working in NextJS HOT 1
- webpack4中每次修改app.js时dll会重新打包 HOT 1
- I use this plugin for react-app,it wiil not inject to the html HOT 1
- TypeError: Cannot read property 'properties' of undefined HOT 1
- multiple dll packages are generated, it will cause duplicate references HOT 2
- Is it support css dll?
- ModuleNotFoundError with Webpack 4
- stats.json are too big HOT 1
- How do I set entryOnly to true to enable treeshaking?
- Plugins are not run when cache is valid
- Autodll-webpack-plugin specifying node_modules in different projects
- what is the right context for a monorepo setup?
- inject the DLL bundles into the html fail HOT 5
- add path parameter html script src can add /
- Cannot add property autodllStatsRetrieved, object is not extensible HOT 3
- how to use this plugin with create-react-app & craco ? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autodll-webpack-plugin.