Coder Social home page Coder Social logo

Comments (4)

asfktz avatar asfktz commented on May 24, 2024

I agree that pify is more suited if it was only for promisifying callbacks.
If fact, I used it earlier in the project.
But I really like bluebird's non-standard API.

Take a look at createMemory:

export const createMemory = (fs, cacheDir) => () => {
  const mfs = new MemoryFileSystem();

  return fs.readdirAsync(path.join(cacheDir, 'bundles'))
    .catch(() => [])
    .map(filename => join(
      filename,
      fs.readFileAsync(path.join(cacheDir, 'bundles', filename)))
    )
    .map(([filename, buffer]) => {
      mfs.writeFileSync(`/${filename}`, buffer);
    })
    .then(() => ({
      getBundles: getBundles.bind(null, mfs)
    }));
};

Isn't it much nicer to have the ability to map over promises like that?
What do you think?

(BTW, just notice I better change the second map to each, since it only contains a side effect and it's not mapping anything)

from autodll-webpack-plugin.

sudo-suhas avatar sudo-suhas commented on May 24, 2024

Sorry.. I didn't see that carefully. I like the Bluebird.map too. There is p-map though. But it's better to use bluebird than add 2 dependencies.

from autodll-webpack-plugin.

asfktz avatar asfktz commented on May 24, 2024

If I only count the times (or PRs) that you showed me that I didn't look carefully enough 😉

from autodll-webpack-plugin.

sudo-suhas avatar sudo-suhas commented on May 24, 2024

@asfktz Ha ha.. 2 sets of eyes better than 1

from autodll-webpack-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.