Please don't use Ctrl-K for previewing about asciidoctor-vscode

[AndyGee]

+1 Yes, really bad key combi - Also ctrl+kr opens the keymap and not the preview.

[gdamore]

Because of this bug, I cannot use this extension! Ctrl-K is a standard binding on all UNIX platforms (including Linux and MacOS) in shells, editors (emacs and vsc of course!) and means delete-to-EOL.

Overriding that (and not giving me any way to turn that override off means that your extension (which is otherwise quite interesting) is more trouble to me than its worth. (This keybinding is wired into my brain.)

[gdamore]

This is not an "enhancement" request, it's a bug! in fact, this keybinding stomps on all other modes, so that ctrl-k doesn't work when editing program source code (.c files), not just asciidoc files!

[gdamore]

Actually, the rebinding of Ctrl+Shift+R overrides another action (refactor) as well. I don't use that, so it isn't as onerous to me, but it strikes me that overriding keybindings unconditionally is a bad idea in any event, and really should not be done at all unless its easily undone.

[gdamore]

Reading the guidance for VSC extension developers, it may be simple enough to just change the Ctrl-K to add a mac binding of CMD-K R, etc. I'll prepare a PR to this effect.

[gdamore]

From what I can see, even cmd+k r is used, but cmd+k shift+cmd+r is not. I'll set up that mapping.

[gdamore]

actually cmd+k shift+r is easier.

[joaompinto]

"ctrl+k shift+r" does not work on Linux (at least with gnome3), I am changing to "ctrk+k r, hope it works on windows.

[gdamore]

ctrl-k is still evil on Linux, and in retrospect, maybe we shouldn't have used that at all. I'm not sure what the Linux port does -- I guess it doesn't use the "mac" bindings.

On all UNIX platforms, ctrl-k should clear-to-end-of-line, by itself.

[joaompinto]

On Linux VSCode just uses ctrl-k as a sequence holder, it just shows "Waiting for second key of chord.." and waits for the next key. Legacy UNIX keybindings have no meaning in modern editors :P