Comments (10)
+1 Yes, really bad key combi - Also ctrl+kr opens the keymap and not the preview.
from asciidoctor-vscode.
Because of this bug, I cannot use this extension! Ctrl-K is a standard binding on all UNIX platforms (including Linux and MacOS) in shells, editors (emacs and vsc of course!) and means delete-to-EOL.
Overriding that (and not giving me any way to turn that override off means that your extension (which is otherwise quite interesting) is more trouble to me than its worth. (This keybinding is wired into my brain.)
from asciidoctor-vscode.
This is not an "enhancement" request, it's a bug! in fact, this keybinding stomps on all other modes, so that ctrl-k doesn't work when editing program source code (.c files), not just asciidoc files!
from asciidoctor-vscode.
Actually, the rebinding of Ctrl+Shift+R overrides another action (refactor) as well. I don't use that, so it isn't as onerous to me, but it strikes me that overriding keybindings unconditionally is a bad idea in any event, and really should not be done at all unless its easily undone.
from asciidoctor-vscode.
Reading the guidance for VSC extension developers, it may be simple enough to just change the Ctrl-K to add a mac binding of CMD-K R, etc. I'll prepare a PR to this effect.
from asciidoctor-vscode.
From what I can see, even cmd+k r is used, but cmd+k shift+cmd+r is not. I'll set up that mapping.
from asciidoctor-vscode.
actually cmd+k shift+r is easier.
from asciidoctor-vscode.
"ctrl+k shift+r" does not work on Linux (at least with gnome3), I am changing to "ctrk+k r, hope it works on windows.
from asciidoctor-vscode.
ctrl-k is still evil on Linux, and in retrospect, maybe we shouldn't have used that at all. I'm not sure what the Linux port does -- I guess it doesn't use the "mac" bindings.
On all UNIX platforms, ctrl-k should clear-to-end-of-line, by itself.
from asciidoctor-vscode.
On Linux VSCode just uses ctrl-k as a sequence holder, it just shows "Waiting for second key of chord.." and waits for the next key. Legacy UNIX keybindings have no meaning in modern editors :P
from asciidoctor-vscode.
Related Issues (20)
- Preview scroll offset wrong when includes are used HOT 1
- Make error more prominent
- Preview scroll offset wrong when working with tables HOT 1
- Disabling SSL verification HOT 2
- Syntax highlighting broken if a variable is used with bash source
- Preview not rendering checkboxes in checklist
- Ctrl + Alt + V break HOT 1
- [Windows Only][Antora Support] `include::example$something` not working on windows
- Cant use asciidoctor in my own extension as soon as i active asciidoctor-vscode extension HOT 7
- Antora preview doesn't work if version is not specified in antora.yml
- Callout and Syntax Highlighting in code blocks
- Right-click causes incorrect multi-select behavior HOT 3
- xrefstyle is not honored when displaying xrefs HOT 2
- Table display issue
- [Feature Request] Point asciidoc.preview.asciidoctorAttributes to file which holds attributes HOT 2
- Verse delimited block syntax breaks syntax highlighting. HOT 1
- Section syntax highlighting stop working when adding extra space to a table separator (`|== `) HOT 2
- reduce frequency of antora support prompt HOT 1
- ${workspaceFolder} on windows has a leading slash. it must not.
- Make it easier to activate/deactivate Antora support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from asciidoctor-vscode.