MrAdvice.Foody 1.1.9.0 Nuget, compilation error about mradvice

[picrap]

This is strange: the current version of Mr. Advice uses Fody 1.29.3 and Cecil 0.9.6.1 which are both the latest version of their product. So your error shows a request for Cecil 0.9.6.0, and this what I don't understand. Is there any way I can reproduce your problem?

[hhblaze]

TestMrAdvice.zip
So, I have created a blank DLL project and added Mr.Advice from Nuget. It can't be compiled. Complete project is embedded.

[picrap]

For some strange reason (I also had this problem once), your version of Fody (on which Mr. Advice relies) was outdated. Upgrading from 1.28 to 1.29 fixes the build.
I wanted to upload the fixed solution in a zip, but GitHub tells me it does not want it (WTF?).
Anyway, just upgrade Fody and you'll get a working solution. If it's OK, you can close this issue... And let me know what do you think of Mr. Advice 😉

[hhblaze]

I have manually UPGRADED to Fody 1.29.3, and fixed FodyWeavers.xml to

<?xml version="1.0" encoding="utf-8"?>
<Weavers>
  <MrAdvice />
</Weavers>

..now it works, thank you!

[hhblaze]

Mr.Advice will be under huge load test, PostSharp must go...

[picrap]

Mr. Advice is open source, so you're free (and welcome) to contribute.
Why leaving PostSharp? (I did the same, but I like to read other opinions).

[hhblaze]

PostSharp is not a part of open stack, that is bad for huge projects.
We use only two aspects for all modules in our architecture. Performance counter and logged try..catch surrounding. For every method in DLLs is counted quantity of calls and execution time. We can monitor it real-time and make decision about the quality of the code.
But PostSharp wants something more and always grows, makes some breaking changes.
Actually now, we've a group of developers which still work with their modules on VS2012 and have to use PS v.3 (can't use v4) and others work with VS2015 where they MUST use PS v.4.

What is good in PS, in compare with all others AOP frameworks, is that they change IL code of the weaved method self, instead of making a wrapper:

return (string)Invocation.ProceedAdvice(this, null, MethodBase.GetCurrentMethod(), MethodBase.GetMethodFromHandle(methodof(Class1.Test​()).MethodHandle), false, null);

PS must be a bit faster.