Coder Social home page Coder Social logo

Comments (7)

arunoda avatar arunoda commented on July 29, 2024

okay, good suggestion. Actually phantomJS is used for spiderable package.
For SEO. Some may might now require it.

On Fri, Jan 31, 2014 at 2:20 AM, Mehdi Hasan Khan
[email protected]:

Hi,
It would be great if you can make nodejs and phantomjs installation
optional, like you already did with mongodb (I'm curious though, why
installing phantomjs mandatory with mup setup?). Some might have node
already installed on server or may prefer to use nvm to manage different
node versions.

Thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com/zodern/meteor-up/issues/22
.

Arunoda Susiripala

@arunoda http://twitter.com/arunoda
http://gplus.to/arunodahttps://github.com/arunoda
http://www.linkedin.com/in/arunoda

from meteor-up-legacy.

arunoda avatar arunoda commented on July 29, 2024

Anyway, can you send me a pull request with the change?

from meteor-up-legacy.

mugli avatar mugli commented on July 29, 2024

Sure! I'll make the change on this weekend and send a pull request.

from meteor-up-legacy.

arunoda avatar arunoda commented on July 29, 2024

Awesome.

On Fri, Jan 31, 2014 at 4:27 AM, Mehdi Hasan Khan
[email protected]:

Sure! I'll make the change on this weekend and send a pull request.

—
Reply to this email directly or view it on GitHubhttps://github.com/zodern/meteor-up/issues/22#issuecomment-33744091
.

Arunoda Susiripala

@arunoda http://twitter.com/arunoda
http://gplus.to/arunodahttps://github.com/arunoda
http://www.linkedin.com/in/arunoda

from meteor-up-legacy.

mugli avatar mugli commented on July 29, 2024

Do you want me to bump version in package.json or will you do that yourself later (if pull request is accepted)?

from meteor-up-legacy.

arunoda avatar arunoda commented on July 29, 2024

I will bump the version.

On Friday, January 31, 2014, Mehdi Hasan Khan [email protected]
wrote:

Do you want me to bump version in package.json or will you do that
yourself later (if pull request is accepted)?

—
Reply to this email directly or view it on GitHubhttps://github.com/zodern/meteor-up/issues/22#issuecomment-33747042
.

Arunoda Susiripala

@arunoda http://twitter.com/arunoda
http://gplus.to/arunodahttps://github.com/arunoda
http://www.linkedin.com/in/arunoda

from meteor-up-legacy.

mugli avatar mugli commented on July 29, 2024

Thanks for accepting the PR. Closing the issue now.

from meteor-up-legacy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.