Comments (2)
I'd propose the following change to the engine._save method
async def _save(
self, instance: ModelType, session: "AsyncIOMotorClientSession"
) -> ModelType:
"""Perform an atomic save operation in the specified session"""
for ref_field_name in instance.__references__:
sub_instance = cast(Model, getattr(instance, ref_field_name))
await self._save(sub_instance, session)
fields_to_update = instance.__fields_modified__ | instance.__mutable_fields__ | {ODMBaseField(key,instance.model_config) for key, value in instance.model_computed_fields.items() if value.repr}
if len(fields_to_update) > 0:
doc = instance.model_dump_doc(include=fields_to_update)
collection = self.get_collection(type(instance))
try:
await collection.update_one(
instance.model_dump_doc(include={instance.__primary_field__}),
{"$set": doc},
upsert=True,
session=session,
)
except pymongo.errors.DuplicateKeyError as e:
raise DuplicateKeyError(instance, e)
object.__setattr__(instance, "__fields_modified__", set())
return instance
from odmantic.
I support this change, I am facing the same issue.
from odmantic.
Related Issues (20)
- Embedded models have to be defined before any normal models that reference them HOT 4
- Question: how to mock/write propper unittests HOT 2
- when a model has many optional field, it will raise unwanted validation type error HOT 4
- Aggregation support via the find method HOT 2
- Datetime not updating and not updating frequently
- Injected Context for Model Class not picked up
- Unexpected @field_validator behaviour
- ODMantic is incompatible with pydantic version 2.7.0 HOT 4
- Custom fields serialisation & deserialisation HOT 1
- Motor uses ThreadPoolExecutor, it drastically decreases a performance HOT 4
- `key_name` doesn't work when field is `id` HOT 2
- The "Custom field types" doc talks about a __bson__ method with an example that doesn't include it
- Field support exclud
- __bson__ serialization does not work when Optional / Union used with Custom Types
- Can't save a model with a field of type pydantic.AnyUrl
- Optional Embedded model and key_name not working HOT 5
- Using Model.model_construct breaks attr setters
- High Memory Usage when Iterating over cursor with many document
- AIOEngine的最佳实践是什么,
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from odmantic.