Nominal weights when correcting already weighted original about hep_ml

[arogozhnikov]

Hello Dan,

here is how weight prediction is implemented

In [2]: GBReweighter.predict_weights??
Signature: GBReweighter.predict_weights(self, original, original_weight=None)
Source:   
    def predict_weights(self, original, original_weight=None):
        """
        Returns corrected weights. Result is computed as original_weight * reweighter_multipliers.

        :param original: values from original distribution of shape [n_samples, n_features]
        :param original_weight: weights of samples before reweighting.
        :return: numpy.array of shape [n_samples] with new weights.
        """
        original, original_weight = self._normalize_input(original, original_weight)
        multipliers = numpy.exp(self.gb.decision_function(original))
        return multipliers * original_weight

So multiplication is done for you (as the last line says), just use the output of this method. Note that during training of reweighter you should also provide weights that you previously used to correct Dp, then it should work as expected.

Also note that second step of correction may break corrections of the first step if you don't require reweighter to correct Dp too. In many practical situations you may not care about that if D and Dp are quite independent.