System→Freeze(Disable Armbian kernel upgrades) not work for new kernel naming about config

[rpardini]

Hey,

• how does armbian-config freeze stuff? If it's apt-mark hold xxx...
• ... that doesn't prevent possible upgrades from being listed in apt list --upgradable ...
• ... but does prevent an actual apt upgrade from upgrading them.

Not saying we don't have some kind of problem with the version, but...

[iav]

sudo apt upgrade
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Calculating upgrade... Done
The following packages have been kept back:
  qemu qemu-user-static
The following packages will be upgraded:
  bind9-dnsutils bind9-host bind9-libs containerd.io distro-info-data dnsutils
  docker-buildx-plugin docker-ce docker-ce-cli gh imagemagick
  imagemagick-6-common imagemagick-6.q16 libldb2 libmagickcore-6.q16-6
  libmagickwand-6.q16-6 libwbclient0 **linux-dtb-edge-meson64
  linux-headers-edge-meson64 linux-image-edge-meson64** linux-tools-common
  python3-ldb python3-samba samba samba-common samba-common-bin samba-libs
  samba-vfs-modules
28 upgraded, 0 newly installed, 0 to remove and 2 not upgraded.
Need to get 152 MB of archives.
After this operation, 1,169 kB of additional disk space will be used.
Do you want to continue? [Y/n]

I add ** to mark linux-dtb-edge-meson64
linux-headers-edge-meson64 linux-image-edge-meson64 inside terminal output

[rpardini]

Ok so this is about armbian-config and how it actually freezes the packages. Do you know where the source for that feature lies?

[iav]

There

config/debian-config-jobs

Lines 958 to 977 in ce33cd3

	check_if_installed linux-u-boot-${BOARD}-${BRANCH} && PACKAGE_LIST+=" linux-u-boot-${BOARD}-${BRANCH}"
	check_if_installed linux-image-${BRANCH}-${LINUXFAMILY} && PACKAGE_LIST+=" linux-image-${BRANCH}-${LINUXFAMILY}"
	check_if_installed linux-dtb-${BRANCH}-${LINUXFAMILY} && PACKAGE_LIST+=" linux-dtb-${BRANCH}-${LINUXFAMILY}"
	check_if_installed linux-headers-${BRANCH}-${LINUXFAMILY} && PACKAGE_LIST+=" linux-headers-${BRANCH}-${LINUXFAMILY}"
	# new BSP
	check_if_installed armbian-${LINUXFAMILY} && PACKAGE_LIST+=" armbian-${LINUXFAMILY}"
	check_if_installed armbian-${BOARD} && PACKAGE_LIST+=" armbian-${BOARD}"
	check_if_installed armbian-${DISTROID} && PACKAGE_LIST+=" armbian-${DISTROID}"
	check_if_installed armbian-bsp-cli-${BOARD} && PACKAGE_LIST+=" armbian-bsp-cli-${BOARD}"
	check_if_installed armbian-${DISTROID}-desktop-xfce && PACKAGE_LIST+=" armbian-${DISTROID}-desktop-xfce"
	check_if_installed armbian-firmware && PACKAGE_LIST+=" armbian-firmware"
	check_if_installed armbian-firmware-full && PACKAGE_LIST+=" armbian-firmware-full"
	local words=( $PACKAGE_LIST )
	local command="unhold"
	IFS=" "
	[[ $1 == "Freeze" ]] && local command="hold"
	for word in $PACKAGE_LIST; do apt-mark $command $word; done | dialog --backtitle "$BACKTITLE" --title "Packages ${1,,}" --progressbox $((${#words[@]}+2)) 64
	fi

[iav]

Seems it should work now.
But it doesn't.
And possible I found a reason: I use an edge kernel now. but ${BRANCH} in check code looks for current.
Highly likely™ in past I just deinstall old kernel packages and install self-builded edge.

Then now question is "what should be a right".

[iav]

Should this code still look for branch at some config? or try to look for real?

[rpardini]

Yeah, I dunno. I'm under strict medical orders to not look into armbian-config source, so I can only speculate that it looks at the info produced by the bsp-cli package in /etc/armbian-release and similar. so if you installed an edge kernel with apt it might be... confused.

[iav]

okay.
Thank you for co-operations.
seems nothing should be fixed there.
Sorry for disturb.

[rpardini]

🖖 You don't disturb at all. We've also BSPFREEZE=yes in build system so this actually helps