Coder Social home page Coder Social logo

Comments (5)

bengaineyarm avatar bengaineyarm commented on August 15, 2024

Hi @bjacklyn - thanks for this.

What tag / version are you attempting to build/use. I am not able to repro this for 7.5, 7.6, 7.7 or our current internal development build.

If you are using an older version, is their any reason you need the combination of old Streamline version + brand new GCC version?

from gator.

bjacklyn avatar bjacklyn commented on August 15, 2024

Ah I should have said the version -- it's 7.1 -- the reason for that is it's another team which decides which version of dependencies they want to use, whereas I'm just upgrading the compiler to the latest.

In the latest versions this must be transitively available from somewhere else, but I do think it's worthwhile to IWYU and it's also a trivial fix -- I've manged to workaround it by creating this patchfile in our build system:

diff --git a/daemon/linux/perf/PerfBuffer.h b/daemon/linux/perf/PerfBuffer.h
index 083ca4d..fdd0aae 100644
--- a/daemon/linux/perf/PerfBuffer.h
+++ b/daemon/linux/perf/PerfBuffer.h
@@ -9,6 +9,7 @@
 #ifndef PERF_BUFFER
 #define PERF_BUFFER
 
+#include <cstddef>
 #include <map>
 #include <set>
 #include <vector>

from gator.

bengaineyarm avatar bengaineyarm commented on August 15, 2024

Ah I should have said the version -- it's 7.1 -- the reason for that is it's another team which decides which version of dependencies they want to use, whereas I'm just upgrading the compiler to the latest.

Ok, thanks.

In the latest versions this must be transitively available from somewhere else, but I do think it's worthwhile to IWYU and it's also a trivial fix

Yes agreed, thank for pointing it out.

I've manged to workaround it by creating this patchfile in our build system:

Great

from gator.

clementperon avatar clementperon commented on August 15, 2024

#40

from gator.

bengaineyarm avatar bengaineyarm commented on August 15, 2024

Resolved by #40

from gator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.