Comments (4)
Good point! In my opinion, the current methods are useful and needed so I'd leave them as is.
New traits/methods sound like a good idea to me. Ideally they'd be wrappers that check validity and maybe one that multiplies by the cofactor, but that should be marked clearly. That bit us on the gadget side when we migrated our pre-refactor gadgets to the new constrain system.
from algebra.
@kobigurk @paberr do you have any thoughts around this? We could have a separate trait that handles the boundary conversions, and leave AffineCurve
to be only prime order.
from algebra.
One idea would be to put these methods in SWModelParameters
and in TEModelParameters
(I don't see how to put them in ModelParameters
, because the trait doesn't understand the notion of AffineCurve
.
from algebra.
We now have a new_unchecked
which doesn't check for subgroup membership, and have changed new
to instead do the on-curve and in-subgroup checks.
(These methods were anyway methods on the structs, and not part of the corresponding traits.)
from algebra.
Related Issues (20)
- Implement improved squaring algorithms HOT 1
- Allow to overwrite the default implementations of `multi_miller_loop`, `final_exponentiation` and `msm` HOT 14
- OSS-Fuzz integration HOT 3
- Optimised `sqrt` variants HOT 2
- Implement `CanonicalSerialize` for `BigUint`
- MontFp failure
- Oversight in `fn test_sw_properties()` ? HOT 3
- Unecessary Vec in HashToField HOT 4
- Evaluating zero polynomial panics
- Remove bench-templates HOT 3
- Possibility of non-u128 implementation of BigInteger HOT 2
- docs.rs can't build documentation for 0.4 HOT 2
- sqrt infinite loop in 0.4.0 HOT 1
- create new ark-group crate HOT 1
- Create a new curve point from x and y HOT 1
- could not find `bls12_381` in `ark_test_curves` HOT 3
- Relaxing the CurveGroup ScalarMul trait bound HOT 5
- Passing Field specification to DenseUVPolynomial giving error HOT 1
- Allow passing an error message to `SerializationError::InvalidData` enum variant HOT 1
- Field: UniformRand HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from algebra.