Coder Social home page Coder Social logo

Comments (3)

reintroducing avatar reintroducing commented on July 28, 2024

+1 to this, looks like all the things I want out of this wonderful script have already been filed :) The readme states that it supports requirejs but it actually doesn't work unless you shim the library properly and export responsiveNav. Removing the shim breaks the require link and it throws an error. This should be implemented properly and can be done relatively easily (http://javascriptplayground.com/blog/2012/10/making-your-library-amd-compliant/).

from responsive-nav.js.

reintroducing avatar reintroducing commented on July 28, 2024

I actually just tried this and all it takes is this:

window.responsiveNav = responsiveNav;

if (typeof window.define === "function" && window.define.amd) {
    window.define("responsiveNav", [], function() {
      return window.responsiveNav;
    });
}

I forked your repo and added the change but to be 100% honest I'm still trying to wrap my head around pull requests and git in general so this is my best way to communicate this to you :)

from responsive-nav.js.

timkelty avatar timkelty commented on July 28, 2024

+1

from responsive-nav.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.