Multiple Menus about responsive-nav.js

[juliankrispel]

Not supported I guess, I'll be making a pull request shortly for this.

[giorgio79]

Fantastic! Most sites have a main menu, plus a user menu, so this update is essential. What is the hold up with getting this committed? More reviews are needed?

[momendo]

@viljamis seems to be more responsive on Twitter than on Github. @juliankrispel What do you need? A review or maybe you need to summerize the patch for @viljamis

[juliankrispel]

@momendo I've summarized it well enough in my pull request I believe. the plugin author just needs to react. I can't accept a pull request for him, because it's not my repository.

[arielsalminen]

@momendo @juliankrispel The reason why I haven't merged this yet is that this doesn't seem to calculate the height correctly. For me it returns height always as "undefined" if the new option is used, which then breaks the transition.

Another issue, but not that big one, is that this pull request doesn't follow the guidelines which can be found here: https://github.com/viljamis/responsive-nav.js/blob/master/CONTRIBUTING.md

[juliankrispel]

thanks for responding @viljamis I'll update my pull request shortly

[arielsalminen]

@juliankrispel I think the problem is this line (L386) and that it's never actually true:

if (typeof nav.inner === "array") { … }

If you update the pull, can you also format all the code as the rest of the code has been formatted (using double quotation marks and similar spacing) and make sure that there are no typos? (I spotted few).

Also, is this line (L382) really needed?

window.e = nav.inner;

[juliankrispel]

will do! thanks again! Ouch, did I leave that in there. My bad, I appear to have rushed that pull request...

[giorgio79]

Looks like here is a working patch #45

[arielsalminen]

This is now supported.