Tabindex necessary? about responsive-nav.js

[arielsalminen]

@davatron5000 This is a good question, so would love to hear some more input on this matter.

[jshawl]

In case you end up removing the tab-index option jshawl@f29b957

[davatron5000]

It might be good to expose this setting through the API, because it could be good for some applications, but only as a conditional enhancement. Like:

if(opts.tabIndex) {
  setAttributes(toggle, {
    "tabindex": opts.tabIndex
  }
}

Then the default would just be 0 or false. I guess it depends if its necessary for the plugin to work. I think the general rule of thumb for tabindex is: "if you don't need it, don't use it".

[arielsalminen]

@davatron5000 I like that approach. Based on this, I would probably remove it completely from the defaults and use something like that.

But also: not sure if it needs a setting at all(?) as one can also use “customToggle” option and write his/her own html for the toggle if needed.

[arielsalminen]

@davatron5000 Decided to remove the whole option after considering this more, so closing this issue.

If someone feels it's needed, we can continue the discussion here. :-)

[davatron5000]

@viljamis I think that's a good call! I looked into it more and it seems that fussing with tab-index typically results in disaster. So yay! Nice work. New favorite plugin 🍔