Comments (3)
@phyzical Im not sure actually as the use cases we have get the restart always init containers added at pod creation via mutation webhooks (istio and gcsfuse csi)
It may be possible to manually edit the live rollout object to have the correct restart policy (similar to other cases where argo doesnt want to change things due to managed fields) but I suspect you will get a validation error there too
I recall from [https://github.com//issues/3130](this bug) that the deployment part of the rollout spec is validated against the k8s libraries deployment validation which would be fine since its a valid 1.28+ spec deployment spec except that rollouts is built against the 1.26 k8s apis
That said, it looks like the 1.7 branch is built against 1.29 as of this commit 2dc71e3 which should at least get it to validate
from argo-rollouts.
We will also need to add logic to allow the spec to support redinessProbe and startupProbe for initContainers
with the restartPolicy
set to Always
spec.template.spec.initContainers[1].readinessProbe: Forbidden: may not be set for init containers
side question,
@martynd are you able to confirm that the rollout spec works with restartPolicy
when i try to add this i find that the live manifest never adds its but i do see it in the desired manifest?
from argo-rollouts.
I gave "release-1.7" tag a go, didn't help sadl.
turns out i missed part of the error from before its actually is invalid: spec.template.spec.initContainers[1].readinessProbe: Forbidden: may not be set for init containers without restartPolicy=Always
So i wondered if the restart policy for normal containers propagated, and it turns out it doesnt for that either.
that makes me think this is by design and couuuld explain the side effects your experiencing ? @martynd
Ill have another sniff at the source to see if theres any comments as to why it does this
edit: hmmm but i see this ref
Ah actually, the helm's crds still havn't been updated so pining the containing to 1.7 doesn't help the crd side ofc
After manually applying the updated crd all works as expected thanks 🦆
from argo-rollouts.
Related Issues (20)
- Support Dynamic Stable Scale without Traffic Routing
- All Nginx ingress paths are included in each canary ingress HOT 1
- How to configure Argo Rollout UI Dashboard in Existing Argocd UI HOT 1
- Controller should return reconciliation error to Rollout object with exponential backoff
- Argorollout Experiment Duration Should Override Success
- Job Analysis Run never fails when the job image can't be pulled (it just succeeds and promotes). HOT 1
- During the Canary deployment, the Stable ReplicaSet temporarily drops to zero and then recovers, causing brief downtime.
- Canary deployment w/ 5 steps with a total of 10m of waits, takes ~3.73h to complete HOT 1
- [Rollouts dashboard] Load time improvements by caching 5mb javascript bundle
- Argo Rollouts needs a custom annotation option for canary ingresses HOT 1
- Argo rollout not synchronizing new git image change after RolloutAborted state HOT 2
- Unable to pull docker image
- We need to scale up pods with warm-up by canary deployment, but it doesn't
- Some logs are in text format ignoring logformat json HOT 2
- Canary deployment causing 503s after reaching 100% setWeight
- Argo controller had rolled out negative values during the promotion HOT 1
- Argo Rollout Canary Service with HTTPS not working
- Argo rollouts controller terminating preview pod when rolling back into previous version HOT 2
- Controller metrics: Add additional labels to time series from custom resources HOT 1
- miss makezero in slice init
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from argo-rollouts.