Loading from disk about distilabel

[dvsrepo]

hey! thanks, the function expects a Path object from pathlib.

It's not a division. In this context, the / operator is used by the pathlib module to join paths, so path / TASK_FILE_NAME combines them into a full file path.

Are you passing a Path object?

cc @plaguss

[dvsrepo]

Oh, I'm not. I assumed it behaved like the datasets "load_from_disk" method and I'm just giving a string. I admit, I didn't read the docs super carefully and can see the "PathLike" type now, but it also says "Path to the dataset, as you would do with a standard Dataset" which isn't quite true.

Yes I fully agree with should accept a string, thanks for the heads up! We'll consider it!

[plaguss]

Hi @cmcmaster1, will try to clarify the function, thanks!

[cmcmaster1]

Change to a path join?

os.path.join(path, TASK_FILE_NAME)

[cmcmaster1]

Oh, I'm not. I assumed it behaved like the datasets "load_from_disk" method and I'm just giving a string. I admit, I didn't read the docs super carefully and can see the "PathLike" type now, but it also says "Path to the dataset, as you would do with a standard Dataset" which isn't quite true.