Comments (55)
Huzzah
Looks like it's working again. :)
Both the Start a test now
option and the hourly tests. 🥳
from pihole-speedtest.
- which browser are you using?
- Are there any logs on the browser console?
from pihole-speedtest.
Ahh good call.
Those Invalid date values seem to only show up on Safari.
iOS iPadOS macOS
I don't have safari installed on my windows machine.
from pihole-speedtest.
Seeing one warning error message in the Dev Console:
[Warning]
Deprecation warning: value provided is not in a recognized RFC2822 or ISO format.
moment construction falls back to js Date(), which is not reliable across all browsers and versions.
Non RFC2822/ISO date formats are discouraged. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info. (moment.min.js, line 1)
Arguments:
[0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: 2024-01-22 12:24:56 CST, _f: undefined, _strict: undefined, _locale: [object Object]
@http://192.168.1.10/admin/scripts/vendor/moment.min.js:1:3266
Nt@http://192.168.1.10/admin/scripts/vendor/moment.min.js:1:21610
Pt@http://192.168.1.10/admin/scripts/vendor/moment.min.js:1:22166
render@http://192.168.1.10/admin/scripts/pi-hole/js/speedresults.js:51:45
@http://192.168.1.10/admin/scripts/vendor/datatables.min.js:43:471
@http://192.168.1.10/admin/scripts/vendor/datatables.min.js:37:234
F@http://192.168.1.10/admin/scripts/vendor/datatables.min.js:42:186
Ka@http://192.168.1.10/admin/scripts/vendor/datatables.min.js:50:96
R@http://192.168.1.10/admin/scripts/vendor/datatables.min.js:41:450
@http://192.168.1.10/admin/scripts/vendor/datatables.min.js:74:398
k@http://192.168.1.10/admin/scripts/vendor/datatables.min.js:60:486
success@http://192.168.1.10/admin/scripts/vendor/datatables.min.js:61:195
c@http://192.168.1.10/admin/scripts/vendor/jquery.min.js:2:28332
fireWith@http://192.168.1.10/admin/scripts/vendor/jquery.min.js:2:29073
l@http://192.168.1.10/admin/scripts/vendor/jquery.min.js:2:80056
@http://192.168.1.10/admin/scripts/vendor/jquery.min.js:2:82500
from pihole-speedtest.
Thanks for getting the new update! The invalid date in the log is fixed in arevindh/AdminLTE#84
I'll need your help to figure out why the speedtests aren't running even though calling speedtest.sh directly works. Update from my repo then do the following.
curl -sSLN https://github.com/ipitio/pihole-speedtest/raw/ipitio/mod.sh | sudo bash -s up
Now run pihole -a -sn
and about a minute or two later check the web interface to see if a test ran. Did it?
And for the scheduled ones, could you show me the output of these two commands:
systemctl status pihole-speedtest.timer
systemctl status pihole-speedtest
The timer should always be active (waiting)
, and the service should be inactive (dead)
unless a scheduled test is running.
from pihole-speedtest.
Sorry for the delay @ipitio & thank you for helping figure this out. :)
Updated via your repo.
Which seems to have resolved the date issue.
But then the pihole-Speedtest.timer command seems to freeze and fail to run correctly?
Looks like the pihole-Speedtest-timer is waiting but the command gets stuck on on lines 1-7/7 (END)`
from pihole-speedtest.
Here's the output for
systemctl status pihole-speedtest
from pihole-speedtest.
Doesn't look like either of those commands added Speedtest results to the Speedtest Log
from pihole-speedtest.
Oh yeah, to get out of the (END) thing you have to press ctrl+c
.
So the run test now button works now, or was that using pihole -a -sn
?
Those commands are just to check whether the schedule is active, the speedtest script itself adds results to the log. Are scheduled tests running?
from pihole-speedtest.
@town3r could you update from my repo again (using the pipe-to-bash, not the button in settings) and let me know if everything still works for you. I've made a few more changes..
from pihole-speedtest.
Looks like it's still working!
Including the run test now button.
Did you move the graph below total queries & client activity or had it always been at the bottom.
It was in the middle previously right? lol
Anything else I should look out for?
from pihole-speedtest.
Does this link work for anyone?
https://c.speedtest.net/speedtest-servers-static.php
from pihole-speedtest.
Yeah I reorganized/revamped settings, allowing any number of hours or days to be input, moved the chart down, and made a bunch of little fixes.
What do you think of having the chart under the other two? I moved it because it seemed, to me, to interrupt the stacked bar charts, considering it's either not stacked or not a bar chart. Did you like it better between?
That link returns XML so doesn't work in iOS Safari. I'm not sure what the new Safaris can do, but maybe you can download the page (which should download the XML). I could probably do something about this..
from pihole-speedtest.
What do you think of having the chart under the other two? I moved it because it seemed, to me, to interrupt the stacked bar charts, considering it's either not stacked or not a bar chart. Did you like it better between?
I like it! I had just gotten used to it being in the middle.
That link returns XML so doesn't work in iOS Safari. I'm not sure what the new Safaris can do, but maybe you can download the page (which should download the XML). I could probably do something about this..
Good catch, had to use a safari extension for it to show up as not blank.
from pihole-speedtest.
If you wanna review the latest changes before they get merged, now would be a good time to update using my repo again :)
from pihole-speedtest.
Updated!
Searching for any changes :D
from pihole-speedtest.
Oh nice!
That show closest server box is 🔥
from pihole-speedtest.
Hmm the results in the Server list seem to be kinda random or off compaired to running speedtest -L
.
Oh duh, it's just pulling w/e is outputted on https://c.speedtest.net/speedtest-servers-static.php
Which for me only lists one server in my city, where speedtest -L
lists 5 in my city and a good number of additional options close by.
Not to go totally off the rails, do you think you could make it so hitting Show closes servers
triggers speedtest -L
being ran instead of pulling from speedtest-servers-static.php
?
from pihole-speedtest.
Hmm the results in the Server list seem to be kinda random or off compaired to running
speedtest -L
.Oh duh, it's just pulling w/e is outputted on
https://c.speedtest.net/speedtest-servers-static.php
Which for me only lists one server in my city, where
speedtest -L
lists 5 in my city and a good number of additional options close by.Not to go totally off the rails, do you think you could make it so hitting
Show closes servers
triggersspeedtest -L
being ran instead of pulling fromspeedtest-servers-static.php
?
Can you try https://www.speedtest.net/api/js/servers?engine=js&limit=10&https_functional=true
from pihole-speedtest.
Those look much better
from pihole-speedtest.
Alright, I updated it to use that link, you should have all your servers now. I'd use speedtest -L
but it seems to have a bug when called from a php environment that causes it to fail.
Actually, I do use it, and since it's failing, it's failing over to the link.
from pihole-speedtest.
Amazing!
Looks much better now. :)
from pihole-speedtest.
Amazing!
Looks much better now. :)
Changes merged, can you check if everything is fine?
from pihole-speedtest.
I'm getting this after first attempt at the reinstall mod under settings:
Thanks for using Speedtest Mod!
Script by @ipitio
Wed Jan 31 14:42:48 CST 2024
Restoring Pi-hole...
HEAD is now at be05b0f6 v5.21 (#2860)
HEAD is now at a2772d43 Merge pull request #83 from ipitio/master
Updating Pi-hole...
[i] Update local cache of available packages...
�[K [✓] Update local cache of available packages
[i] Existing PHP installation detected : PHP version 7.4.33
[i] Checking for git...
�[K [✓] Checking for git
[i] Checking for iproute2...
�[K [✓] Checking for iproute2
[i] Checking for dialog...
�[K [✓] Checking for dialog
[i] Checking for ca-certificates...
�[K [✓] Checking for ca-certificates
[i] Checking for updates...
[i] Pi-hole Core: up to date
fatal: HEAD does not point to a branch
Error: Remote revision could not be obtained, please contact Pi-hole Support
Additional debugging output:
HEAD detached at v5.21.1
nothing to commit, working tree clean
Installing Mod...
HEAD is now at eacbe336 we're already at the latest tag
Previous HEAD position was eacbe336 we're already at the latest tag
HEAD is now at a8687511 Merge branch 'arevindh:master' into speedOverTimeChart
HEAD is now at 17cb5839 Merge pull request #84 from ipitio/master
Previous HEAD position was 17cb5839 Merge pull request #84 from ipitio/master
HEAD is now at a2772d43 Merge pull request #83 from ipitio/master
cp: cannot stat '/opt/mod_pihole/advanced/Scripts/speedtestmod': No such file or directory
Process Aborting...
HEAD is now at 6bf07e2a higher
Previous HEAD position was 6bf07e2a higher
HEAD is now at 17cb5839 Merge pull request #84 from ipitio/master
Please try again or try manually.
from pihole-speedtest.
And now these after attempting @ipitio update script and then yours @arevindh
from pihole-speedtest.
I have a fix submitted for that. Right now you can run the script with "un" to uninstall, then without args or with "up" to install
from pihole-speedtest.
from pihole-speedtest.
Any idea what's causing these errors when trying to update?
from pihole-speedtest.
Tried to uninstall and reinstall but it fails.
from pihole-speedtest.
I went through the manual uninstall steps and found the Web Interface still shows as VDEV (Head, V5.21.3)
I think everything else uninstalled correctly.
Ope pihole -r
restored it back to default.
from pihole-speedtest.
I think there is some issue with curl command
try this sudo apt install gnutls-bin
from pihole-speedtest.
from pihole-speedtest.
That seems to be related to the fatal error, I think, which #157 should fix
from pihole-speedtest.
Nice!
Any idea when the fixes will be pushed out? 😄
from pihole-speedtest.
I guess now haha
from pihole-speedtest.
I think it worked.
Other than the error from Pihole directly.
from pihole-speedtest.
Huh I guess I didn't fix it, but now I have a better idea of why that happens. To test my hypothesis, could you update using my dev repo? If I'm right, you won't encounter the issue because it doesn't pin admin to a tag for dev purposes.
curl -sSLN https://github.com/ipitio/pihole-speedtest/raw/ipitio/mod.sh | sudo bash -s up
from pihole-speedtest.
I think #159 should fix it.
from pihole-speedtest.
Two issues currently.
-
Unable to update the Testing interval value to anything but 0 resulting in no tests running.
-
Unable to update.
from pihole-speedtest.
I'll try uninstalling and reinstalling the mod fresh.
from pihole-speedtest.
No dice.
from pihole-speedtest.
Ooh a new error, I'll get right on that.
What exactly happens with the testing interval? You try setting it to some positive value, but when hitting confirm it goes back to 0?
from pihole-speedtest.
Yup!
When the Mod was installed, anything other than 0 entered in that field after saving and the auto refresh of the page, it would be back to 0.
Didn't see anything pop-up in the recent logs when clicking the button.
from pihole-speedtest.
Could you try installing the mod from my repo? I have verbose logging enabled there so I can see where exactly that error happens.
curl -sSLN https://github.com/ipitio/pihole-speedtest/raw/ipitio/mod.sh | sudo bash
I also can't reproduce the testing interval issue; what does the "show status" say after you try changing the interval?
from pihole-speedtest.
Fresh install via your repo seems to work successfully.
The testing interval issue also seems to be gone as well.
Schedule is inactive is what it used to say.
Where now it's active w/ a count don to next run.
from pihole-speedtest.
That's interesting. Well, since it's working for you now let's wait till sid merges my latest PRs and see if it still doesn't work for you then.
from pihole-speedtest.
Once merged, should I uninstalled, and then reinstall fresh from his repo?
Could switching between the two repos when running the upgrade command be breaking things?
from pihole-speedtest.
You should be able to just upgrade with the script in sid's repo. Upgrading, uninstalling, even switching repos should be transparent.
The only difference in sid's repo is a check for the latest release so that you don't get any yet-untagged changes that may/may not work. I suspect it's this check that could be causing issues but not sure.
from pihole-speedtest.
Got this after seeing the update was pushed early this morning.
from pihole-speedtest.
@town3r If the following works for you, I'll merge the PR.
curl -sSLN https://github.com/ipitio/pihole-speedtest/raw/ipitio/mod.sh | sudo bash -s up
from pihole-speedtest.
from pihole-speedtest.
from pihole-speedtest.
Try again, I pushed the wrong tag
from pihole-speedtest.
Also, it's -s up
if you want to run the update!
from pihole-speedtest.
from pihole-speedtest.
Related Issues (20)
- Speedtest mod breaks Pi-Hole updates HOT 16
- Pi-hole FTL v5.22, Web v5.19 and Core v5.16.1 released HOT 5
- When specific speed test server unavailable, speedtest fails HOT 2
- Another new Pi-hole release - v5.17 HOT 5
- Error installing through script HOT 2
- Clear History doesn't seem to work HOT 3
- New Pi-hole 5.17.2 just released HOT 2
- New Pi-Hole web interface - v5.21 HOT 3
- Speedtest Returns "No Internet Connection" HOT 9
- one liner install does not work HOT 9
- [Feature request] Docker Container HOT 4
- Unable To install in Debian Bullseye GPG not found HOT 1
- "Start time" column shows "Invalid date" after pihole update HOT 13
- Build docker-compose Graph not displayed HOT 1
- add support for librespeed
- Speedtest manual server entry and times of speedtests are incorrect HOT 24
- [Feature Request] Show version mod in Speedtest tag HOT 15
- Speedtest option still on dashboard even though already removed HOT 7
- [Info] Crontab expression in Testing interval HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pihole-speedtest.