Coder Social home page Coder Social logo

Comments (6)

RobinTail avatar RobinTail commented on June 4, 2024 1

Perhaps I had this issue when marked 5.1.2 was not yet released, so it resolved to 5.1.0 when I tried to install your package.

I can confirm that at the moment there is no issue installing your package on Node 16:

$ yarn add @arethetypeswrong/cli
yarn add v1.22.11
[1/4] πŸ”  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] πŸ”—  Linking dependencies...
[4/4] πŸ”¨  Building fresh packages...
success Saved lockfile.
success Saved 17 new dependencies.
info Direct dependencies
└─ @arethetypeswrong/[email protected]
info All dependencies
β”œβ”€ @andrewbranch/[email protected]
β”œβ”€ @arethetypeswrong/[email protected]
β”œβ”€ @arethetypeswrong/[email protected]
β”œβ”€ @colors/[email protected]
β”œβ”€ [email protected]
β”œβ”€ [email protected]
β”œβ”€ [email protected]
β”œβ”€ [email protected]
β”œβ”€ [email protected]
β”œβ”€ [email protected]
β”œβ”€ [email protected]
β”œβ”€ [email protected]
β”œβ”€ [email protected]
β”œβ”€ [email protected]
β”œβ”€ [email protected]
β”œβ”€ [email protected]
└─ [email protected]
$ nvm current
v16.13.2

@andrewbranch

from arethetypeswrong.github.io.

RobinTail avatar RobinTail commented on June 4, 2024 1

πŸŽ‰

from arethetypeswrong.github.io.

andrewbranch avatar andrewbranch commented on June 4, 2024

Does it actually fail in Node 16 due to marked, or is this just a warning? My intention is to support Node 16 until the end of its maintenance window, which is in... two weeks πŸ˜„

from arethetypeswrong.github.io.

RobinTail avatar RobinTail commented on June 4, 2024

Hello @andrewbranch ,

Your package can not be installed in environment having Node 16 (at least without --ignore-engines flag of yarn) because of marked's constraints.

Here is was the output of my CI workflow when I tried:

### Run yarn install
yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version ">= 18". Got "16.20.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Error: Process completed with exit code 1.

Currently I'm going to drop Node 16 in my library, so I'm beginning using your package in my CI.

from arethetypeswrong.github.io.

RobinTail avatar RobinTail commented on June 4, 2024

Correction, @andrewbranch , sorry:
I found out that later marked fixed this. It was >=18 in v5.1.0, but already in v5.1.2 they fixed it to >= 16.

from arethetypeswrong.github.io.

RobinTail avatar RobinTail commented on June 4, 2024

Therefore, @andrewbranch , in order to support Node 16, I'd suggest to adjust the version of marked in your package.json:

- "marked": "^5.1.0"
+ "marked": "^5.1.2"

from arethetypeswrong.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.