String Index OOB in endpoint with no params. about openapi-parser

[aress31]

I am not totally convinced that the reported issue is due to the code that you pointed out. Indeed, before entering the loop where the removal of the final coma happens there is an implemented check to ensure that the we have got at least one valid parameter to process: if (params != null).

Furethemore, I am personally able to parse swagger files containing empty parameters with no problem.

Could you please provide more information? Ideally (if possible) send me the swagger file that you are trying to parse with the swagger-parser/swurg via email so I can have a deep look into the issue.

[adetlefsen-rms]

Example swagger file that causes the error:

{
  "swagger": "2.0",
  "info": {},
  "host": "some.server.com:20666",
  "basePath": "/http://some.server.com:20666",
  "tags": [
    {
      "name": "analysis"
    },
    {
      "name": "generic"
    }
  ],
  "schemes": [
    "http"
  ],
  "paths": {
    "/": {
      "get": {
        "operationId": "get",
        "parameters": [],
        "responses": {
          "200": {
            "description": "successful operation",
            "schema": {
              "type": "string"
            },
            "headers": {}
          }
        }
      }
    }
  }
}

[aress31]

Thanks, I am going to have a look at this tomorrow. But at first sight, I would say that that removing that line:
"parameters": [], could solve the issue since I suspect the List<Parameter> params to contain an empty Parameter instead of null.
/Alex

[adetlefsen-rms]

I can't guarantee what the target site has in its swagger definition! I'd rather the plugin handle that...

[aress31]

The target website still has to have a valid swagger definition!

That's the prerequisite for the plugin to work, swurg does not have to validate the swagger definition; there is already plenty of websites available for that.
As I already said, I will have a look at the issue and IF it is an exception not-handled by swurg I will fix it, otherwise you will have to obtain a properly formatted swagger file!

Swurg is not a bug free plugin and all reported issues are appreciated when properly documented.

This is an on-going project (cf. readme.md) and finding issues is quite normal.

/Alex

[adetlefsen-rms]

It is perfectly valid for parameters to be an empty array in the swagger definition.

Understood that this is an on-going project and that your valuable time goes into it. I appreciate it.