[Bug]: Repeat flag set even when keys are differents about arduino-irremote

[ArminJo]

Thanks for reporting.
I documented it in the sources now.
IRDATA_FLAGS_IS_AUTO_REPEAT means: The current repeat frame is a repeat, that is always sent after a regular frame and cannot be avoided. Only specified for protocols DENON, and LEGO.
IRDATA_FLAGS_IS_REPEAT means: The gap between the preceding frame is as smaller than the maximum gap expected for a repeat. !!!We do not check for changed command or address!!!

[Franck78]

We do not check for changed command or address!!!

ah, maybe at link level most of this info (IRDATA_FLAGS) is useful. But at application level, there is no use for this.

This detection can be done at app level but really each decoder is the most suited place to do it accurately .

Can you think of it please ? Use bit 0x20 for that.

[ArminJo]

In many protocols, it is not possible to distinguish between two fast presses of the same button and one long press.
And it is almost not possible to press 2 different buttons on the remote within around 100 ms.
And the check consumes around 85 bytes of program memory.

[Franck78]

Yeah, but as you know, you also wrote the Sender. And the sender has no problem sending codes at 'normal' throughput. Inserting a fake 'human' delay makes zero sense.

Detecting this reliably is mandatory. Without that, it simply means that all Senders can be removed from the repo except for one that has to be to made resistant to this usage.

The advantage of having them all (for sending) is choosing the one with less resources usage on one side, or best error detection, or shorter frames or compatible with the boxe of remote you mistakenly ordered ;)

At least do it between ifdefs for one protocol (say RC6). It will be 500% better done than any other contrib.

[Franck78]

ArminJo added theses lines in commit ad0425f

and every decoded protocol is calling it.

#if defined(ENABLE_FULL_REPEAT_CHECK)
            && decodedIRData.address == lastDecodedAddress && decodedIRData.command == lastDecodedCommand /* requires around 85 bytes program space */
#endif

IRDATA_FLAGS_IS_REPEAT can be trusted.