Make slackWebHook optional about cloudflare-pages-slack-notification

[arddluma]

Hello @salexpro ,
I've just made SlackWebHook optional, feel free to try arddluma/[email protected]and let me know :)
However, you also have the option to unsubscribe to deployment events in GitHub Slack app /github unsubscribe owner/repo deployments
Thanks!

[arddluma]

hey @salexpro, could you please clarify this. I don't understand the use case here.
It is not a problem to make it optional but I don't understand the reason for this.
Thanks in advance!

[salexpro]

Sorry if I confused you a little. So the thing is that we already have github connected to our slack and it's sending deploy messages which are this action adds to PRs

and basically, there's no need to "duplicate" that info with another slack app/webhook

I think it would be nice to make slackWebHook: ${{ secrets.SLACK_WEBHOOK }} an optional thing since we're already getting status messages from GitHub and it's also one less secret to add to every new repo

[arddluma]

Thanks for your response!
Ah, I see! But the whole point of this action is to send Slack notifications with additional info like deployment id ,url and also logs to make it easier and not via GitHub deployments notifications.
I will make it optional in the next release 🙏

[salexpro]

Thanks! Much appreciated!

[arddluma]

@salexpro could you please close this issue once you are satisfied with it :) Thanks!

[salexpro]

Sure, thanks!