Comments (7)
Hello @salexpro ,
I've just made SlackWebHook optional, feel free to try arddluma/[email protected]
and let me know :)
However, you also have the option to unsubscribe to deployment events in GitHub Slack app /github unsubscribe owner/repo deployments
Thanks!
from cloudflare-pages-slack-notification.
hey @salexpro, could you please clarify this. I don't understand the use case here.
It is not a problem to make it optional but I don't understand the reason for this.
Thanks in advance!
from cloudflare-pages-slack-notification.
Sorry if I confused you a little. So the thing is that we already have github connected to our slack and it's sending deploy messages which are this action adds to PRs
and basically, there's no need to "duplicate" that info with another slack app/webhook
I think it would be nice to make slackWebHook: ${{ secrets.SLACK_WEBHOOK }}
an optional thing since we're already getting status messages from GitHub and it's also one less secret to add to every new repo
from cloudflare-pages-slack-notification.
Thanks for your response!
Ah, I see! But the whole point of this action is to send Slack notifications with additional info like deployment id ,url and also logs to make it easier and not via GitHub deployments notifications.
I will make it optional in the next release 🙏
from cloudflare-pages-slack-notification.
Thanks! Much appreciated!
from cloudflare-pages-slack-notification.
@salexpro could you please close this issue once you are satisfied with it :) Thanks!
from cloudflare-pages-slack-notification.
Sure, thanks!
from cloudflare-pages-slack-notification.
Related Issues (9)
- Feature suggestion: use api token HOT 4
- [BUG] no_service error HOT 5
- Wait for a specific environment or branch HOT 1
- [BUG] Use Node 20 warning HOT 2
- Always throwing error when lastState = "build" HOT 5
- Some warnings from the package HOT 5
- Using action with workflow_dispatch gives TypeError: Cannot read properties of undefined (reading 'url') HOT 6
- [BUG] Skipped Deployment Runs Indefinitely HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloudflare-pages-slack-notification.