Comments (8)
This is the intended behavior.
from cliki2.
Much better behavior is 404 error. Not 500, not application code.
from cliki2.
Well designed 404 page have to be shown. Not 'server error'.
from cliki2.
There are 404 pages for articles and accounts. Revision IDs are permanent (except for "permanently deleted" pages ie spam) - if there is an error in viewing revisions or comparing them, then there is either an error in the URL or a serious server error. So 500 is the right behavior. All 500 pages return a stack trace to make error reporting easier.
from cliki2.
Ошибка валидации не должна приводить к 500 никогда.
Почитай что ли книжку. 4xx -- ошибка клиента. 5xx -- ошибка сервера.
P.S. С таким подходом толку от этого сайта не будет.
from cliki2.
Еще добавлю - на живом сайте пользователь никогда не должен видеть никаких стектрейсов. Это потенциальная уязвимость. Максимум - сообщение "Упс! Что-то пошло не так, мы уже в курсе и работаем над этим" и все ошибки логировать.
from cliki2.
Опять повторяю: это не ошибка валидации. Это или ошибка в базе данных, или ошибка в генерации URL. Если кто-то хочет найти уязвимость, то может спокойно прочитать код. А стек трейс упрощает дебаггинг для меня и пользователей cliki. Это же сайт для программистов.
from cliki2.
Пробел в url был добавлен пользователем. Он набрал url по-памяти (например).
http://cliki2-beta.cliki.net/site/view-revision?id=10000000
А это ошибка в базе или ещё где?
from cliki2.
Related Issues (20)
- Menu links HOT 2
- code tags HOT 2
- Add a Change Password feature HOT 4
- The edit summary is silently truncated to 128 characters
- Show edit summary in diff
- "transactions" to bundle related changes across many pages without "spamming" the changelog HOT 1
- Is there something like the old cliki's `?source`
- START-CLIKI-SERVER fails with reference to "index" HOT 3
- Change site title to include "Common Lisp Wiki" HOT 1
- sbcl-internals.cliki.net is down HOT 11
- 500 Error From asdf-install
- Troubles signing in... HOT 5
- search for urls
- Legibility on small devices could be improved
- How does one escape close parenthesis in an internal page name? HOT 1
- Able to create page with no title, impossible to edit afterwards HOT 3
- User can save pure js-code in Edit summary field HOT 1
- History view pops up (debug?) messages HOT 2
- User can use pure js-code as username HOT 1
- README HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cliki2.