TypeError if no trips were found about ns-api

[aquatix]

Good one. Currently it catches the error from the NS XML API and prints "Error in trips: Geen geldige 'fromStation' opgegeven", returning None (as the input is 'faulty'), but I guess an empty list would work just as well. Going to change that now and push a new version.

Thanks!

[bartromgens]

The input is valid in this case, meaning that the fromStation is in the list of stations given by nsapi.

Your fix does not resolve the problem. 'error' in obj is False so it moves on to for trip in obj['ReisMogelijkheden']['ReisMogelijkheid'] and then raises a TypeError exception. That is at least what happens for me.

I am fine with None or empty list as return from get_trips. Just not a TypeError exception.

[aquatix]

Oh my bad, I copied your example and there's "Utrecht Central" in there (mind the single 'a'), so I got a different error. Apparantly I need more coffee, as your issue is with something else entirely. Just reproduced, going to fix now.

[bartromgens]

Ah, my bad as well. Typo in the example that reproduces the error :) Sorry. Thanks for looking into it.

[aquatix]

No worries :) Shall I return None in both cases, or an empty list? I prefer None, as that shows that something went wrong.

[bartromgens]

Yes, I also prefer None.

[bartromgens]

Great. Thanks!