Coder Social home page Coder Social logo

Comments (1)

iyehuda avatar iyehuda commented on June 8, 2024 1

This is a real problem, akthoug I think the relevant code is at https://github.com/aquasecurity/kube-query/blob/master/tables/volumes.go#L89-L107
You can see there that only the last iterated volume is appended to the row slice.

Applying this diff fixed the problem:

--- a/tables/volumes.go
+++ b/tables/volumes.go
@@ -94,14 +94,14 @@ func (t *VolumesTable) getVolumesFromAllPods() []*VolumeRow {
        }
        volumes := make([]*VolumeRow, 0)
        for _, pod := range pods.Items {
-               currentVolume := &VolumeRow{}
                if pod.Spec.Volumes != nil {
                        for _, volume := range pod.Spec.Volumes {
-                               currentVolume.volume = &volume
-                               currentVolume.fromPod = pod.Name
+                               volumes = append(volumes, &VolumeRow{
+                                       volume: volume.DeepCopy(),
+                                       fromPod: pod.Name,
+                               })
                        }
                }
-               volumes = append(volumes, currentVolume)
        }
        return volumes
 }

Any thoughts on how we should handle such a scenario?

I think your proposal is great.
This way each volume is a separate entry.

from kube-query.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.