Coder Social home page Coder Social logo

Comments (3)

laggingreflex avatar laggingreflex commented on May 20, 2024

Fixed in #46

from sicksync.

laggingreflex avatar laggingreflex commented on May 20, 2024

This doesn't yet work exactly like .gitignore. While the gitignore files are parsed correctly, chokidar's ignored option works slightly differently that git's mechanism of ignoring paths from gitignore.

For example it doesn't work on a deeper level. If you have .cache in your .gitignore and src/something/.cache it won't be ignored. It'll only ignore ./cache (from root)

This has come up before too in #47 but I think this particular detail was missed earlier.

I think at least a warning should be added that while sicksync does parse gitignore it doesn't work exactly like it.

Or it should try to make it work? In the above example if I wanted .cache to be ignored a level deeper I'd have to make the rule **/.cache/**, so should it just add **/ before every gitigore rule? I remember I made a PR for doing exactly this in paulmillr/chokidar#539 but, at least from chokidar's perspective, it might not have been a good idea.

What would be the best approach?

from sicksync.

laggingreflex avatar laggingreflex commented on May 20, 2024

This also doesn't work for bigSync (at all, not just the issue in above comment)

edit: fixed in #89

from sicksync.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.