Coder Social home page Coder Social logo

Comments (4)

dnadoba avatar dnadoba commented on June 3, 2024

We should also upgrade some of the Int types that express file sizes to Int64 so 4GB+ sizes can actually be supported on 32bit systems. I think this only affects the byteCount parameter of readChunked. This can be done separately and will need to preserver and deprecate the old function signatures. Note that offset is already Int64.

from swift-nio.

weissi avatar weissi commented on June 3, 2024

We should also upgrade some of the Int types that express file sizes to Int64 so 4GB+ sizes can actually be supported on 32bit systems. I think this only affects the byteCount parameter of readChunked. This can be done separately and will need to preserver and deprecate the old function signatures. Note that offset is already Int64.

We don't need > 32 bit chunks. Reasonable chunk sizes are in kiB or MiB

from swift-nio.

dnadoba avatar dnadoba commented on June 3, 2024

Agree but I'm talking about the byteCount parameter, not the chunkSize parameter of the readChunked(...) method.

from swift-nio.

weissi avatar weissi commented on June 3, 2024

Agree but I'm talking about the byteCount parameter, not the chunkSize parameter of the readChunked(...) method.

Fair enough!

from swift-nio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.