Coder Social home page Coder Social logo

Special case macros? about swift-format HOT 4 OPEN

sbdchd avatar sbdchd commented on August 20, 2024
Special case macros?

from swift-format.

Comments (4)

allevato avatar allevato commented on August 20, 2024 2

That's another option, if folks prefer

@objc
func reallyLongFunctionName(
  arg: Arg
) {

over

@objc func reallyLongFunctionName(
  arg: Arg
) {

I don't really have a strong opinion as long as it's consistent. But I'm not swayed too much by @objc(selector) because the selector is typically going to be long enough that the likelihood is high that it'll force whatever is after it to wrap anyway, so I don't think carving out a way to keep @objc(selector) on the same line makes sense.

from swift-format.

allevato avatar allevato commented on August 20, 2024 1

Syntactically, there's nothing that distinguishes attached macros from other attributes, so we can't special case them.

I think the example you're showing is one where attributes/macros in general can be improved, though. The same thing happens with long availability macros:

struct SettingsView: View {
  @available(iOS 16.0, tvOS 16.0, watchOS 10.0, macOS 15.0) private var blockedUsers:
    [BlockedUserModel]
}

I think we could make the change that if any of a declaration's attributes has parenthesized content, then we force the declaration to start on its own line after the attributes. That would solve this case but avoid putting unnecessary line breaks before simple things like @objc.

from swift-format.

ahoppen avatar ahoppen commented on August 20, 2024

Synced to Apple’s issue tracker as rdar://133811486

from swift-format.

j-f1 avatar j-f1 commented on August 20, 2024

There’s also the case of @objc(selector). Maybe the attributes should only be split onto multiple lines if the declaration as a whole (excluding the body) needs to be broken up?

from swift-format.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.