Coder Social home page Coder Social logo

Make forum creation optional about direct-app HOT 10 OPEN

ajefts avatar ajefts commented on August 15, 2024
Make forum creation optional

from direct-app.

Comments (10)

ajefts avatar ajefts commented on August 15, 2024

@deedee @Schpotsky @skyhit Would you have any interest in coding this change?

from direct-app.

ajefts avatar ajefts commented on August 15, 2024

cc: @rootelement

from direct-app.

mtwomey avatar mtwomey commented on August 15, 2024

Notes:

  1. In this below: This receives the call from Work Manager, it needs to also receive an option to not create the Jive forums.

https://github.com/appirio-tech/ap-challenge-microservice/blob/25ee7903ee710079d5fb1f6371037b30971ce151/src/main/java/com/appirio/service/challenge/resources/ChallengeResource.java#L206

  1. In this below: When it calls direct it needs to somehow pass in the option to not create the Jive forums:

https://github.com/appirio-tech/ap-challenge-microservice/blob/25ee7903ee710079d5fb1f6371037b30971ce151/src/main/java/com/appirio/service/challenge/directmanager/ContestDirectManager.java#L846

  1. In direct, recognize the option to not create the Jive forums and then don't create them:

public SoftwareCompetition createSoftwareContest(TCSubject tcSubject, SoftwareCompetition contest,

  1. Add logging - TBD

from direct-app.

rootelement avatar rootelement commented on August 15, 2024

@kylewu if you're bored and want to take a look here too :)

from direct-app.

Schpotsky avatar Schpotsky commented on August 15, 2024

@ajefts
I have some other tasks to do now.
I may look into it later when I have some time if still not implemented

from direct-app.

kylewu avatar kylewu commented on August 15, 2024

@ajefts how could I test this locally? I remember there is a repo with docker setup

from direct-app.

kylewu avatar kylewu commented on August 15, 2024

added https://github.com/appirio-tech/ap-challenge-microservice/pull/549

from direct-app.

kylewu avatar kylewu commented on August 15, 2024

@ajefts @rootelement I believe there was an issue with my previous PR: the interface was not updated

@rootelement ap-challenge-microservice needs to upgrade dependency contest_service_facade, otherwise it won't compile

from direct-app.

rootelement avatar rootelement commented on August 15, 2024

@kylewu we had merged this to dev, but had to pull it back out. can you make an updated PR?

from direct-app.

kylewu avatar kylewu commented on August 15, 2024

@rootelement #554 here it is

from direct-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.