Comments (3)
I can take a look at this one, but if something is priority, I request the team to handle it due to my time constraints.
from appflowy.
Since this was originally implemented by you @MayurSMahajan , I wonder if you want to also work on improvements and bug fixes for inline document search?
from appflowy.
Hey @Xazin,
So after observing this issue, I have noticed two things:
- For scroll freeze: There is a
jumpTo()
method call which causes the editor to shift all content down and get frozen there. - For selected text getting replaced after pressing enter: This only happens when the focus is not on the Find Text Input field. Thus the Enter key event causes the editor to replace the selected text, rather than navigating to the next match.
I have solved the first part of the issue by removing the jumpTo()
call, since anyway making a new selection causes the editor to scroll to the selected content. I will create a PR for this in the AppFlowyEditor repo.
I need some help tackling the second part.
Approach 1: I tried implementing Shortcuts, Actions, and Intent to listen to the Enter
key event on the FindReplace
widget to kind of intercept the Enter
key event before it is handled by the Editor itself, which as expected, deletes the selected content. But I am not able to do it.
Approach 2: I wrapped the FindReplace
widget with KeyboardEventListener
, this too causes the editor to take over and insert a newline after handling the onKeyEvent
.
Can you give me a hint for deciding a strategy towards stopping the editor from deleting the content?
Anyway, I will continue brainstorming, just updating everyone on the current progress of the issue.
from appflowy.
Related Issues (20)
- [Bug] Black screen after second launch [LINUX][FLATPAK][WAYLAND] HOT 7
- [FR] Hello, friend! Is it possible to change the image and video rendering engine?
- [Bug] Too narrow sidebar in settings
- [FR] about setting http_proxy in the application
- [Bug] Neither Favorites and Spaces are displayed in sidebar HOT 1
- [FR] database rollups
- [FR] db AI formula
- [Bug] There seems to be a small issue on macOS (M2): German Keyboard layout. I can zoom out, but not in anymore.
- [Bug] 0.6.1. Blank Page on startup, Windows 10 HOT 2
- [FR] document format menu polish
- [Bug] wrong download link in winget's repo HOT 4
- [Bug] Button overlap themselves in sidebar for workspace
- [FR] Permit to choose the disposition of section
- [Bug] Wrong width of section selection menu HOT 1
- [Bug] Sync status is gone
- [Bug] how to generate protobuf file HOT 1
- [Bug] The Application does not open on android HOT 2
- [Bug] 0.6.1 release artifacts are zipped twice HOT 1
- [FR] Move page to another space HOT 1
- [Bug] Missplaced icon in callout
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from appflowy.