Coder Social home page Coder Social logo

[FR] Darkmode about appflowy HOT 23 CLOSED

appflowy-io avatar appflowy-io commented on May 4, 2024 23
[FR] Darkmode

from appflowy.

Comments (23)

notd5a-alt avatar notd5a-alt commented on May 4, 2024 6

Ok, im going to try to work on this feature for you guys.

from appflowy.

mrtolkien avatar mrtolkien commented on May 4, 2024 4

To start maybe using an open color scheme like Solarized, Monokai, or Dracula would be simpler?

This way there would be no need to reinvent the wheel and users of those themes will feel right at home.

from appflowy.

annieappflowy avatar annieappflowy commented on May 4, 2024 3

To start maybe using an open color scheme like Solarized, Monokai, or Dracula would be simpler?

This way there would be no need to reinvent the wheel and users of those themes will feel right at home.

second to your point that using something ppl are familiar with makes ppl feel right at home :D

from appflowy.

rileyhawk1417 avatar rileyhawk1417 commented on May 4, 2024 2

Well I think it would be nice to have custom themes, but for now maybe focusing on Light and Dark theme switches would be a starting point.

from appflowy.

kiralabs avatar kiralabs commented on May 4, 2024 2

A Dark/Light toggle would be nice, but honestly, most people just stick to one 'theme', so even if it was a config file that people can replace by dropping in another and even just a 'Theme Picker' to select a config file, that would be cool :)

Would also be very good in adoption of AppFlowy for people who enjoy ricing all of their programs/utilities like the folks on r/unixporn

from appflowy.

annieappflowy avatar annieappflowy commented on May 4, 2024 2

option 2
I'd even prefer the grey color used for the left panel as the color for the main editor.
This is Obsidian's dark mode - I think it's pretty eye-pleasing
image

from appflowy.

branhillsdesign avatar branhillsdesign commented on May 4, 2024 1

Dark mode options

Please note that these color schemes are not fully realized and accessibility testing will need to be performed

Option 01 Based on the secondary purple brand color

Dark Mode Color Theme

Option 2 based on greys with no tint

Dark Mode Color Theme-1

Option 2 based on blue main brand color

Dark Mode Color Theme-2

Current Light Mode theme

Light Mode Color Theme

Strawpoll Link

https://strawpoll.com/hfarq36rc

from appflowy.

branhillsdesign avatar branhillsdesign commented on May 4, 2024 1

@mrtolkien I looked at various color themes that are popular for IDE's, but unfortunately, almost none of them are WCAG compliant. Which is unfortunate, because some of them are real slick. They also don't cover the majority of use cases an application will have, especially one that uses colors for organization like Appflowy has planned.


With that being said, @annieappflowy has had the entire MVP already designed prior to coming on to the project, so I wanted to essentially expand on the colors that are in-use for the designs already and then double check for accessibility compliance. I did really enjoy Obsidian's dark mode @annieappflowy, and part of that is in this dark mode.


I want to change the names on each of the color variables so that any developer that does want to make a theme for the app in the future will know what each color is used for (This is also why there's duplicate colors, but with different names), or when developing widgets in general, there won't be any guessing on what color goes where. That way the devs can focus on what's important and don't have to think about UI.

Dark Mode Color Theme

Light Mode Color Theme

Feel free to comment or make any suggestions on things.

I also don't know much about dart or flutter, so I could use some help implementing the color themes in the code if someone wants to take the reigns on that.

from appflowy.

SleepDaemon avatar SleepDaemon commented on May 4, 2024

I agree, dark mode is more eye comforting. My eyes are very sensitive to bright lights and just using the app burns into my retinas. Having dark mode would make it more comfortable to use and allowing longer work time.

from appflowy.

MostHated avatar MostHated commented on May 4, 2024

Yeah, I will keep an eye on this thread, because even with my monitor's brightness down, it's just too bright for me to try and use for any extended period of time.

from appflowy.

alilosoft avatar alilosoft commented on May 4, 2024

@annieappflowy @appflowy Are you currently using a custom theme for the material app or just the default?
I'm just getting started with Flutter but I may work on this issue if I get some guidance 💙

from appflowy.

notd5a-alt avatar notd5a-alt commented on May 4, 2024

If anyone isnt working on this is can probably add this feature. Just need to know what the devs / people may want in terms of accent colors.
Also any recommendations for the positioning / placement of the dark mode switch would be appreciated.

from appflowy.

rileyhawk1417 avatar rileyhawk1417 commented on May 4, 2024

@notd5a-alt any progress?
For now am trying to make sure everything matches like font and other backgrounds.

from appflowy.

notd5a-alt avatar notd5a-alt commented on May 4, 2024

from appflowy.

rileyhawk1417 avatar rileyhawk1417 commented on May 4, 2024

Well I am currently working on it was also wondering if anyone else had given it a shot

from appflowy.

branhillsdesign avatar branhillsdesign commented on May 4, 2024

I grabbed the colors from the theme files and working on what dark mode will look like in figma. I’ll have updates with some options this evening to show with color codes that correspond to already existing color tokens.

from appflowy.

SleepDaemon avatar SleepDaemon commented on May 4, 2024

from appflowy.

rileyhawk1417 avatar rileyhawk1417 commented on May 4, 2024

Option 2 seems mellowed out and relaxed

from appflowy.

MostHated avatar MostHated commented on May 4, 2024

2 - with no tint

from appflowy.

rileyhawk1417 avatar rileyhawk1417 commented on May 4, 2024

@mrtolkien I looked at various color themes that are popular for IDE's, but unfortunately, almost none of them are WCAG compliant. Which is unfortunate, because some of them are real slick. They also don't cover the majority of use cases an application will have, especially one that uses colors for organization like Appflowy has planned.

With that being said, @annieappflowy has had the entire MVP already designed prior to coming on to the project, so I wanted to essentially expand on the colors that are in-use for the designs already and then double check for accessibility compliance. I did really enjoy Obsidian's dark mode @annieappflowy, and part of that is in this dark mode.

I want to change the names on each of the color variables so that any developer that does want to make a theme for the app in the future will know what each color is used for (This is also why there's duplicate colors, but with different names), or when developing widgets in general, there won't be any guessing on what color goes where. That way the devs can focus on what's important and don't have to think about UI.

Dark Mode Color Theme Light Mode Color Theme

Feel free to comment or make any suggestions on things.

I also don't know much about dart or flutter, so I could use some help implementing the color themes in the code if someone wants to take the reigns on that.

I hear you right now am trying to implement the dark mode feature, so i can have a starting point. The thing am struggling with is having the text color automatically change with the theme. For example when its dark mode the text is white. When its light mode the text is still white making it not visible since the app theme is light mode.

from appflowy.

Aditya1402 avatar Aditya1402 commented on May 4, 2024

Hi there! This is my first time contributing to Open Source projects.

Can you guide me about how I can contribute towards this good-first-issue? @annieappflowy

from appflowy.

hieugao avatar hieugao commented on May 4, 2024

Hi @Aditya1402, I open a related PR at #259, so in case if you want to contribute some then check it out, ᵖˡᵉᵃˢᵉᵎ 😄. I'll add some tasks inside the PR soon.

from appflowy.

polypixeldev avatar polypixeldev commented on May 4, 2024

@annieappflowy I think that this issue should be closed, as from what I can see Darkmode has already been implemented.

from appflowy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.