Comments (3)
Fixed in 0.5.3
. Thanks @Vlasenko .
from subscriptions-transport-ws.
Seems module format for client-side bundle has changed from CommonJS in 0.5.1 to global var in 0.5.2 by Pull Request:
#77
Maybe libraryTarget: 'umd'
should be used instead in unpkg-webpack.config.js
?
Global var module style for client-side bundle will work without hacks involved only with <script>
tags in web browser. But if one uses webpack
bundler (maybe it is applicable for other bundlers as well), by default it processes browser
field in package.json and hence attempts to use client-side bundle when you require('subscritption-transport-ws')
. In 0.5.1 everything was fine with webpack
, because client-side bundle had CommonJS module style. But in 0.5.2 module style changed to global var and now you need to require this module in rather convoluted way:
require('script!subscriptions-transport-ws');
const SubscriptionClient = SubscriptionsTransportWs.SubscriptionClient;
I propose to not use global var, but rather use the module style for client-side bundle that works BOTH with <script>
tag and with bundlers. I think UMD module style is compatible with any usage scenario.
from subscriptions-transport-ws.
@Urigo The same problem has happened with 0.6.0
. Browser bundle is exported as global var, whereas in 0.5.x it was exported as CommonJS module, is it intended?
from subscriptions-transport-ws.
Related Issues (20)
- How do I pull maxConnectTimeGenerator from SubscriptionClient?
- Subscription unsubscribing when getting a graphQLError HOT 1
- How Do I Know When Subscriptions Ready on Server and Client ??
- Is there any way to pass authorization token to subscribe dynamically?
- CVE-2021-32640 / SNYK-JS-WS-1296835 Regular Expression Denial of Service in [email protected]
- How to fix 'Cannot read property 'id' of 'null'
- A vulnerability was detected in the ws package. HOT 2
- onConnected and onReconnected event do not fire HOT 1
- "Cannot read property 'subscribe' of undefined" HOT 3
- Use async/await in npm distribution to improve stack traces
- Subscription: PubSub.publish() does not trigger event outside of resolver HOT 13
- Next.js + Apollo Server 3.0 + Subscription HOT 2
- How to use at AWS Lambda, use serverless?
- Dependency Dashboard
- socket.protocol is empty string when connecting
- How to use SubscriptionClient to get onclose code information
- GQL_CONNECTION_INIT is sometimes delivered AFTER GQL_START, because connectionParams is resolved asynchronously HOT 1
- Outdated Readme? HOT 3
- Error: Unable to find native implementation, or alternative implementation for WebSocket!
- `.return` is called to unsubscribe a subscription even after it has already thrown an error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from subscriptions-transport-ws.