Comments (4)
alessbell
commented on May 24, 2024
ts-jest should compile the TS and throw type errors, and the test job is running on CI, so this probably isn't needed — I had the same thought re: the apollo-client repo but it turned out this was taken care of by ts-jest, but worth verifying here :)
from apollo-client-devtools.
MrDoomBringer
commented on May 24, 2024
@alessbell good point, I'm now curious as why that test didn't run on #919
from apollo-client-devtools.
alessbell
commented on May 24, 2024
Hmm, good question @MrDoomBringer, since the author is a first-time contributor it's possible they signed the CLA after opening the PR, which has caused issues with CCI PR jobs in the past... maybe try closing + re-opening the PR?
Edit: actually it appears the test job is not run on PRs created via forks, this should be fixed now
from apollo-client-devtools.
alessbell
commented on May 24, 2024
Now that the test job is running against forks, we can see ts-jest indeed fails the test job on tsc error: https://app.circleci.com/pipelines/github/apollographql/apollo-client-devtools/5885/workflows/b1d3d92f-a99b-43a4-84e6-f3d5b78ee2b4/jobs/5892
Closing as not planned.
from apollo-client-devtools.
Related Issues (20)
- Firefox console shows "Attempt to postMessage on disconnected port" from Apollo extension HOT 2
- [bug] Devtools never appear if initial page does not contain an Apollo Client instance HOT 2
- Improve release process
- Remove apollo-link-state support?
- Improving type safety
- Migrate to Manifest V3 HOT 3
- Publish to Firefox store via GitHub Action
- Scroll not working in Queries and Cache tabs. HOT 3
- Display scroll bars in Webkit browsers
- Update screenshots in extension/addon stores HOT 2
- Finish Tailwind migration HOT 1
- Active queries disappear when used with RedwoodJS
- Dependency Dashboard
- Extension prevents websites (tested on atlassian.com) from loading styles HOT 9
- Not working! Apollo Client Devtools on Chrome latest HOT 17
- Doesn't work in latest Chromium-based MS Edge HOT 6
- Server side mutation errors are not reported in the explorer HOT 2
- 'Search Queries' input bar seems out of place
- Extension breaks Remix.run React framework hydration HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apollo-client-devtools.