SimplePathfindingAlgorithm does not support diagonal movement about apollo

[rmcmk]

Diagonal support was never added to the simple path finder. It was one of the issues we didn't get to.

[lare96]

What was the issue preventing you guys from adding it?

[Major-]

There was nothing preventing us from adding support for diagonal movement, we just never got round to it.

Yeah, I finished it :) A slightly different version.

@Major- Mind add me on skype? artembatutin

[lare96]

Artem if you've finished it maybe you should submit a pull request.

[Major-]

@artembatutin I don't really use skype, but you can contact me on r-s, or do what lare said and open a pull request :-)

You do know that I'm banned on r-s? I would still love to share this last work I did. I don't have any forks. And the implementation is quite different too.

[MitchZinck]

Fork it and do a pull request then?

http://pastebin.com/anSQDekr You don't have to jump from one method to another as you did before. Supports diagonal moves. Returns the path once an obstacle is found.

[rmcmk]

...the method propagation is ideal for readability (and being able to understand what is going on) finding horizontal and vertical moves, there isn't a single method name which can appropriately describe both.

Also why would you remove the paste?

It was set for 2 days. I'll post it back once I get on my computer for a bigger amount of time. What I did is that I've created one loop which would end if the pathfinder reached its destination. And while in progress, it would first prioritize diagonal moves, it would still finish the horizontal and vertical moves after. Once a path is blocked(can skip diagonal moves for that), it would break the loop and return what it did gathered.

[rmcmk]

permalink: https://gist.github.com/ryleykimmel/9b9ae062656000da3e22#file-simplepathfinder-java

[lare96]

@ryleykimmel is that okay to be merged into the repo? Or in other words, has it been tested?

[Major-]

Lots of repetition in that code, I'd like to find a way to reduce that before adding it.