Add tests. about apollo

[Major-]

https://github.com/apollo-rsps/apollo/tree/master/test

More on the way when they're necessary.

[kylestev]

Considering this is the core of an RSPS shouldn't it be necessary always? :P
On Dec 23, 2013 4:53 PM, "Major" [email protected] wrote:

https://github.com/apollo-rsps/apollo/tree/master/test

More on the way when they're necessary.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-31152815
.

[Major-]

What other tests do you think are necessary?

[kylestev]

org.apollo.fs could use some love.

org.apollo.game not testing the GameService class. It's pretty simple to do for some of the methods like adding and removing a player so why not do it?

org.apollo.game.sync.task needs some love

Most things in the org.apollo.* should be tested. Even things like adding/removing an element from a data structure should be tested (the method, not the underlying data structure's implementation). I know writing tests are boring and suck to do, but I'd be happy to help contribute some tests later this week. I'd like to see this project finally get some people contributing to and using this project. I wish people realized that sharing progress is the only way for everyone to move forward and advance :( /rant

Thanks for taking the initiative to take over this project from Graham.

Basically anything that's critical to communicating with the client or involves the core's logic.

[Major-]

A GameService test wouldn't be ideal because of the nature of the class, but org.apollo.fs is certainly an idea.