Coder Social home page Coder Social logo

Comments (5)

alerque avatar alerque commented on August 18, 2024 1

https://gitlab.archlinux.org/archlinux/packaging/packages/greetd-tuigreet/-/commit/22d7a576974e29ce2419d1d88a2422380b350bed#9b9baac1eb9b72790eef5540a1685306fc43fd6c_38_37

from tuigreet.

apognu avatar apognu commented on August 18, 2024

Hi,

As far as I know, there shouldn't be any runtime dependency on anything other that on libc (through the uzers-rs crate).

The tests (and only the tests) that are behind the nsswrapper feature, on the other hand, use libnss_wrapper to mock responses from NSS (so we do not have to rely on actual users being present in the test environment).

You can see how it is being used here in the workflow.

I recognize, though, that I should update the README to reflect this information, which is not obvious at all. I apologize for this and will update it as soon as possible.

I remain available to help you through getting the tests to pass, in the meantime.

from tuigreet.

apognu avatar apognu commented on August 18, 2024

I added some instructions in the README as to how to run the whole test suite. Please keep me posted if they are enough of if you feel you need more information.

from tuigreet.

alerque avatar alerque commented on August 18, 2024

Thanks for the explanation and additional docs. So if I understand correctly this is only a testing dependency, not a run time dependency. Since we don't have libnss_wrapper packaged it isn't easy to run that test, but it seems like it's reasonably safe to skip it. Not 100% safe obviously but probably not a great loss on the packaging side since it isn't a true integration test anyway.

from tuigreet.

apognu avatar apognu commented on August 18, 2024

Indeed, it is only a test dependency.

Relatively safe, well that depends on the point of view, the feature calls into unsafe code (FFI to libc) on startup. So technically, it could segfault and prevent the program from working.

Now I do not know a perfect solution here, putting a precompiled shared library in the repository seems a bit shady, and I would prefer not to do that.

from tuigreet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.