Coder Social home page Coder Social logo

Comments (6)

jancurn avatar jancurn commented on July 28, 2024

Also, AutoscaledPool should probably stop launching new tasks. And when all tasks are finished, it could just exit the process with an error exit code, so that the task is migrated to new server.

from crawlee.

jancurn avatar jancurn commented on July 28, 2024

BTW if actor doesn't have "Restart on error" flag set, then we shouldn't send any migration event, since the actor won't be able to handle it anyway

from crawlee.

mtrunkat avatar mtrunkat commented on July 28, 2024

I think that those are two different cases. "Restart on error" means that error in actor is something that may occasionally happen as, for example, memory exceeded when doing big long crawl.

Some of the actors for example - actor that aggregates data from a dataset and sends email is something I want to restart on migration but not on error - because error should not happen there.

from crawlee.

jancurn avatar jancurn commented on July 28, 2024

You're right, this should probably be other setting - e.g. "Fail on migration"

from crawlee.

mnmkng avatar mnmkng commented on July 28, 2024

Do this once #195 is done.

from crawlee.

mnmkng avatar mnmkng commented on July 28, 2024

Implemented in #268

from crawlee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.