Coder Social home page Coder Social logo

Comments (10)

fracek avatar fracek commented on June 15, 2024

The type definition in starknet.js is wrong. The return value is a weird array with keys(!), the objects are deserialized from a flat felt array to their type (so for example balanceOf has one element that is an uint256 struct). I talked with @janek26 about this, and they're open to a PR that adds type safety around contract calls.

from starknet-react.

janek26 avatar janek26 commented on June 15, 2024

please contribute! :-)

from starknet-react.

fracek avatar fracek commented on June 15, 2024

I will :)

from starknet-react.

fracek avatar fracek commented on June 15, 2024

This is still an issue in v2.

from starknet-react.

HumbertoTM10 avatar HumbertoTM10 commented on June 15, 2024

Is this available to pick up?

from starknet-react.

fracek avatar fracek commented on June 15, 2024

This can be done as part of the work on v3. I will try to organize the effort so you can contribute to it.

from starknet-react.

fracek avatar fracek commented on June 15, 2024

Hey @HumbertoTM10 , you can work on this. Make sure to start your work from next-v3 and make the PR against that branch. A good starting point is studying abi wan and see how it works.

from starknet-react.

HumbertoTM10 avatar HumbertoTM10 commented on June 15, 2024

Hey @fracek, got it! Assign it to me, will work on it!

from starknet-react.

fracek avatar fracek commented on June 15, 2024

Done. Make sure to add tests to test types in your PR.

from starknet-react.

Pet3ris avatar Pet3ris commented on June 15, 2024

Love it

from starknet-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.