Cannot use entity with custom identifier ( != 'id' ) about core

[dunglas]

id is hardcoded in some part of the bundle. As a property called @id is required by JSON-LD, I can sleep with the requirement of having a public $id property or a getId() method defined. Just consider it as the value of @id.

There is nothing preventing to create getId() method even if it's not the property name used by Doctrine. And some edge cases such as composed primary keys are not compatible with JSON-LD anyway.

I don't want to create a hard dependency against Doctrine (we currently use the bundle with other data providers such as Elastic Search, web services...). If you want to make the method used configurable, an entry in https://github.com/dunglas/DunglasApiBundle/blob/master/Mapping/ClassMetadata.php looks better to me.

[MLKiiwy]

Yes, my PR introduce an hard dependancy with doctrine. I'm looking for a better solution to remove that

[dunglas]

My proposal:

1. create a $identifier property in https://github.com/dunglas/DunglasApiBundle/blob/master/Mapping/ClassMetadata.php and in the relative interface with a default value being id
2. create a DoctrineIdentifierLoader in https://github.com/dunglas/DunglasApiBundle/tree/master/Mapping/Loader populating that property using your code
3. load the new loader only if Doctrine ORM is enable (in Resources/config/doctrine_orm.xml).
4. in the IriConverter class (and probably in other part of the bundle), use that metadata

What do you think?

[MLKiiwy]

I think your solution is better and remove the dependancy with doctrine.
I write the code and do a PR this afternoon if it's ok ;)

[dunglas]

Perfect :)