Urgent help needed: Inconsistent PropertyFilter Behavior in API Platform v3 in prod env about api-platform

[dunglas]

Hi,

This will be hard to investigate without a reproducer, or at least more details (DBMS, entities, indexes...).

If it is urgent, feel free to send a mail at [email protected] to hire an expert from our team. I'm sure that it will resolve the issue quickly.

[soyuka]

The property filter is adding attributes to the serialization context dynamically, my first guess is that something is happening in the cache. Try to add attributes at https://github.com/api-platform/core/blob/8e3a488103a51becd9c900ec5a3849b806121fbf/src/Serializer/CacheKeyTrait.php#L36 ? We're missing a lot of informations though:

• content type? are you using jsonld or json ?
• usage of the security option with the property filter
• does the problem occurs with or without authentication ?

Please provide a reproducer at the email from the above message.

[simon-fa]

Hello, we're using jsonld and the problem occurs with authentication.

What's absolutely crazy is that if I download the db and all configuration files and I start our app on my computer with exactly the same environment as production, it works well…

I tried to clear cache in production... Nothing.

In IGNORED_ATTRIBUTES, I should add attributes I don't want to cache ?

[soyuka]

In fact it's not the fix as they are present in the $context. Not sure what's going on.

[simon-fa]

I contacted Les Tilleuls this morning, waiting for an answer...

I hope someone can help me there.

[simon-fa]

Could it be due to the fact that my database is still a postgre 13 ?

[simon-fa]

We have probably made some progress in resolving the issue.

After further tests, we were finally able to reproduce the error in a dev env.

So we abandoned the track of the prod env problem.

In desperation, we tried to undo all the work we did to organize nicely our routes and filters into dedicated YAML files for each entity, to put it back in the PHP file, like it was at the origin.

On the tested entities, the bug of the erratic property filters disappeared…

But I can't wrap my head around it… How can it create such an incomprehensible bug ?

[simon-fa]

We undid all this work and put it back in api/src/Entity/Marketing/Campaign.php

`
#api/config/api_platform/marketing/campaign.yaml

resources:
App\Entity\Marketing\Campaign:
operations:
# collectionOperations

        ApiPlatform\Metadata\GetCollection:
            filters:
                [
                    "campaign.search_filter",
                    "campaign.boolean_filter",
                    "campaign.order_filter",
                    "entity.property_filter",
                ]

        # itemOperations
        get_campaign:
            class: ApiPlatform\Metadata\Get
            method: GET
            uriTemplate: the_route
            controller: the_controller
            security: "is_granted('ROLE_role')"
            securityMessage: "Access Denied."

        patch_campaign:
            class: ApiPlatform\Metadata\Patch
            method: PATCH
            uriTemplate: the_route
            controller: the_controller
            security: "is_granted('ROLE_role')"
            securityMessage: "Access Denied."

        ApiPlatform\Metadata\Delete:
            security: "is_granted('ROLE_role')"
            securityMessage: "Access Denied."

        # workflow

        re_deploy_campaign_in_ghl:
            class: ApiPlatform\Metadata\Patch
            method: PATCH
            uriTemplate: the_route
            controller: the_controller
            security: "is_granted('ROLE_role')"
            securityMessage: "Access Denied."

        boss_acceptation:
            class: ApiPlatform\Metadata\Patch
            method: PATCH
            uriTemplate: the_route
            controller: the_controller
            security: "(is_granted('ROLE_role') and user in object.getBusiness().getUsers().getValues()) or is_granted('ROLE_role')"
            securityMessage: "Acces Denied"

        send_draft:
            class: ApiPlatform\Metadata\Patch
            method: PATCH
            uriTemplate: the_route
            controller: the_controller
            security: "(is_granted('ROLE_role') and user in object.getBusiness().getUsers().getValues()) or is_granted('ROLE_role')"
            securityMessage: "Acces Denied"

        geek_validation:
            class: ApiPlatform\Metadata\Patch
            method: PATCH
            uriTemplate: the_route
            controller: the_controller
            security: "is_granted('ROLE_role') or is_granted('ROLE_role')"
            securityMessage: "Acces Denied"

        another_geek_validation:
            class: ApiPlatform\Metadata\Patch
            method: PATCH
            uriTemplate: the_route
            controller: the_controller
            security: "is_granted('ROLE_role') or is_granted('ROLE_role')"
            securityMessage: "Acces Denied"

        another_geek_rejection:
            class: ApiPlatform\Metadata\Patch
            method: PATCH
            uriTemplate: the_route
            controller: the_controller
            security: "is_granted('ROLE_role') or is_granted('ROLE_role')"
            securityMessage: "Acces Denied"

        boss_rejection:
            class: ApiPlatform\Metadata\Patch
            method: PATCH
            uriTemplate: the_route
            controller: the_controller
            security: "(is_granted('ROLE_role') and user in object.getBusiness().getUsers().getValues()) or is_granted('ROLE_role')"
            securityMessage: "Acces Denied"

        cancel:
            class: ApiPlatform\Metadata\Patch
            method: PATCH
            uriTemplate: the_route
            controller: the_controller
            security: "(is_granted('ROLE_role') and user in object.getBusiness().getUsers().getValues()) or is_granted('ROLE_role')"
            securityMessage: "Acces Denied"

        change_mind:
            class: ApiPlatform\Metadata\Patch
            method: PATCH
            uriTemplate: the_route
            controller: the_controller
            security: "(is_granted('ROLE_role') and user in object.getBusiness().getUsers().getValues()) or is_granted('ROLE_role')"
            securityMessage: "Acces Denied"

    denormalizationContext:
        groups: ["write:coach"]

properties:
App\Entity\Marketing\Campaign:
id: ~
name: ~
isActive: ~
dateFrom: ~
dateTo: ~
eventDateTo: ~
eventDateFrom: ~
passVIPduration: ~
budgetAmount: ~
budgetType: ~
offerDescription: ~
prizeDescription: ~
video: ~
guarantee: ~
broadcasts: ~
emailAutomatisms: ~
fbTitles: ~
fbCall2Actions: ~
fbMedias: ~
fbTexts: ~
wcScript: ~
wcPreviewLink: ~
followUpScenari: ~
followUpScript: ~
state: ~
reasonOfRefusal: ~
usersWhoApprove: ~
usersWhoRefuse: ~

    # ghl
    ghlTeamId:
        security: 'is_granted("ROLE_role") or is_granted("ROLE_role")'
    ghlTeam:
        security: 'is_granted("ROLE_role") or is_granted("ROLE_role")'

    # relation
    offer: ~
    services: ~
    marketingPlan: ~
    business: ~

`

`
#api/config/filter/marketing/campaign_filters.yaml

services:

campaign.search_filter:
    parent: 'api_platform.doctrine.orm.search_filter'
    arguments: [ {
        business.id: 'exact',
        business.name: 'ipartial',
        marketingPlan.id: 'exact',
        marketingPlan.isPermanent: 'exact',
        name: 'ipartial',
        state: 'exact',
    } ]
    tags:  [ 'api_platform.filter' ]

campaign.boolean_filter:
    parent: 'api_platform.doctrine.orm.boolean_filter'
    arguments: [ {
        isActive: 'exact',
    } ]
    tags:  [ 'api_platform.filter' ]

campaign.order_filter:
    parent: 'api_platform.doctrine.orm.order_filter'
    arguments:
        $properties: {
            id: ~,
            business.name: ~,
            dateFrom: ~,
            dateTo: ~,
        }
        $orderParameterName: order
    tags:  [ 'api_platform.filter' ]

`