Panic is triggered by none dns packet (?) about opengfw

[taida957789]

It seems to be a problem with gopacket processing none packets (e.g dhcp ack). You may use recover() to handling the panic when any panic was triggered in packet parser.

there is no any buffer size checking at DNSQuestion.decode function

[tobyxdd]

Oops, I had no idea that gopacket would just panic on invalid packets like that. Perhaps the best solution would be to fix DNSQuestion.decode ourselves with a fork and submit a PR?

[taida957789]

Yes, I think so, but from the point of view of using the library, do we need to consider adding a fault-tolerance mechanism to the analyzer?

[tobyxdd]

Turns out the latest version of gopacket already has this fix. I will just upgrade to the new version for now.