index files not working about ngx-fancyindex

[cjmayo]

For me I think this was still OK in 1.9.15 and not working in 1.10.1.

[aperezdc]

It seems that I will need to find out in which version of Nginx things stopped working. One question: are you using fancyindex as a loadable dynamic module, or built into Nginx statically?

[jarischaefer]

Statically

[cjmayo]

Statically also. I've checked, 1.9.15 was OK.

1.9.15 was with Fancy Index 0.3.6
1.10.1 and 1.11.2 with Fancy Index 0.4.0

[tdavis]

Was about to report this. FI 0.4.0 (static) with 1.10.1 ignores index.html here, as well.

[aperezdc]

Thanks for all the comments. I'll check the changes introduced by Nginx and try to fix this issue as soon as I'm back from holidays later this week. Sorry for keeping you waiting!

[aperezdc]

I have just started adding a test suite for the module (see #47), and I am now going to add a couple of test cases which reproduce this issue. It was about time to have tests 😉

[aperezdc]

Okay, I have an explanation for this: in versions after 1.9.11 (which introduced dynamic module support) the following piece of the config file is not ran:

# XXX: Insert fancyindex module *after* index module!
#
HTTP_MODULES=`echo "${HTTP_MODULES}" | sed -e \
  's/ngx_http_index_module/ngx_http_fancyindex_module ngx_http_index_module/'`

That is because after 1.9.11 the new system for configuring modules is used. For dynamic builds I have been already able to fix the issue by setting:

ngx_module_order="$ngx_module_name
                  ngx_http_autoindex_module"

That causes the correct module order to be used when loading the module dynamically. Unfortunately for static builds the $ngx_module_order variable is ignored, and reordering $HTTP_MODULES in the way it was done before 1.9.11 does not work either. I am going through the files in auto/* in the Nginx source code to find out if some workaround could be used.

[aperezdc]

It seems that using the old-style config snippet works even in recent Nginx releases when building the module statically. The following works in all supported versions:

if [ $ngx_module_link = DYNAMIC ] ; then
   # Define $ngx_module_order and source auto/module
else
   # Manually edit $HTTP_MODULES and $NGX_ADDON_SRCS
fi

Soon I will be pushing a fix for this issue 😄

[aperezdc]

The fix is now in master, and the new tests are passing in the CI. Closing.