Comments (4)
I have commented out lines 115-119, line 152, and lines 163-166 of CasSaml1Response.cs. I then compiled the assembly and used it in a test project, using the Saml11 ticket validator, with success. I also tested with the role provider enabled without issue.
As Jetski5822 pointed out, xmlReaderSettings
and authenticationAttributes
are never consumed anywhere in the ProcessValidAssertion()
method, as far as we can tell. Perhaps these are artifacts left over from initial development? If a project maintainer could confirm these findings, I will create a pull request to remove these unused lines and we can close out this old issue?
from dotnet-cas-client.
@hokiecoder @Jetski5822
I think I'm going to take a glance over at the Java and PHP client repos to see what they are doing to get some insight as to what this code might have been used for at one point or intended to be used for.
It looks like @scottt732 implemented these lines of code, but I doubt he's going to remember after 8 years :-/
from dotnet-cas-client.
This is orphaned code that was in the repo, since it was in Git, all the way back to this files first commit by @serac in 50046c7
I didn't do any further research, but it may have been for debugging XML purposes or something carried over from the Java CAS Client project.
I'm going to remove the orphaned code in develop
since this doesn't warrant a hotfix release. I'll be available in the next minor/major release.
from dotnet-cas-client.
@phantomtypist I looked through the Java client code and came to my understanding that the handling of XML documents in .NET is quite different than in Java, so the code doesn't really have much comparison. However, I did look through the docs on the properties that are, in a futile effort, being set in this .NET client's code as mentioned by Jetski5822. I agree with your assessment that the code is orphaned as XmlReaderSettings
is not even used by the XmlDocument
class directly. It seems, to me, that it is useful for when XML is being read from a source with the intention of being (possibly) modified and stored again. But in the case of this project, the XML is just being parsed to create a SAML response object.
Just an FYI to concur with your choice!
from dotnet-cas-client.
Related Issues (20)
- localhost redirected you too many times HOT 13
- [AllowHtml] attribute
- [AllowHtml] attribute HOT 10
- Locked out of HR BLock Canada- really need to get my taxes done so... HOT 2
- SetAuthCookie(ticket) doesn't create any ticket HOT 4
- CAS redirects to servername instead of service HOT 2
- serverName set problem HOT 2
- Testing Experimental CAS v3 Support HOT 6
- Is there any way to ignore specified Controller or Action? HOT 5
- [SingleSignOut] Loop when use CasAuthentication.SingleSignOut in ActionResult HOT 4
- Attributes are not available when using AssertionRoleProvider HOT 1
- Unable to obtain CAS proxy ticket in load balanced environment HOT 4
- /signin-cas?state=xxx HOT 3
- Is it support SAML 2.0 ? HOT 4
- too many redirects HOT 8
- Null ProxyGrantingTicket found
- get user attributes HOT 6
- Do you provide client SDK/library for .net core (3.1)?
- Not redirecting after successful authorization using saml11 ticket validator.
- Support for .net 5?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dotnet-cas-client.