Comments (4)
This is corrected (c2d81c7) with the following being the resolved api. More work should go into this to use the static methods but I'm leaving that for an API clean up
console.log('Device');
console.log(await sunroomD.getDeviceInfo())
console.log(await sunroomD.getFullDeviceInfo())
console.log('Modem');
console.log(await modem.queryDeviceInfo(sunroom));
console.log(await modem.queryFullDeviceInfo(sunroom));
from insteon-plm.
It looks like the Modem function gets the device db info from the cat and subcat.
whereas
the device class does a id request to get cat, subcat, and hardware on device.
I agree these should be named differently.
from insteon-plm.
PowerLincModem.getDeviceInfo
is called by PowerLincModem.queryDeviceInfo
The PowerLincModem.queryDeviceInfo
sends the ID request to the device. What i'm proposing is that we just re-use these static methods provided by the PLM class in the device class so that device.getDeviceInfo
returns the same object as PowerLincModem.getDeviceInfo
.
from insteon-plm.
device.getDeviceInfo
also returns the hardware and firmware version of the particular device but I get where you're coming from and I'm working on a unification of the names
from insteon-plm.
Related Issues (20)
- Delete Link needs to update the device db as well HOT 3
- API Idea list HOT 3
- Todo List HOT 2
- Todo: Convert levels & ramp rates to numbers HOT 1
- Add clamp function and use it HOT 2
- Bug: If both syncLincs and syncInfo are false, the `ready` event doesn't work HOT 1
- Todo: Export the utilities HOT 1
- Send All Link Command Needs to Wait for All Link Cleanup Report HOT 1
- Unlink not worrking correctly HOT 1
- Unlinking keep a responder record on device HOT 1
- `clearDatabaseRecord` isn't making the record inactive HOT 4
- `linkDevice` issue HOT 2
- Process Queue needs a delay HOT 6
- syncLinks does not work with await getDeviceInstance HOT 2
- Device syncLinks produces duplicate links
- Modem timesout when looping over syncLinks command HOT 1
- Modem needs to wait for broadcast command to complete HOT 1
- Look over API for 1.0 release
- Device DB should have number instead of hex strings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from insteon-plm.